From: Greg KH <gregkh@linuxfoundation.org>
To: mourn <mourn@2600fr.org>
Cc: Mark Einon <mark@einon.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
john.stultz@linaro.org, rebecca@android.com
Subject: Re: [PATCH] staging: android: fix coding style
Date: Fri, 14 Mar 2014 23:32:14 +0000 [thread overview]
Message-ID: <20140314233214.GA1124@kroah.com> (raw)
In-Reply-To: <01095ac2f40e88e8736294e68c2fac05.squirrel@ssl0.ovh.net>
On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote:
>
> > The changes look good, however you should be a bit more specific about
> > what the
> > fixes are, and that you used checkpatch.pl to find them (I assume).
> >
>
> Yes, you are right. I can edit the commit log.
>
> > Also, Signed-off-by: should state your full name, which I'm also assuming
> > isn't
> > 'mourn'. Please see Documentation/SubmittingPatches.
> >
>
> I have a bit of a problem here. Some companies forbid their employees to
> openly participate in open source projects. A request to the legal
> department will take around 6 months with no hope of positive result...
Then I can not take your patch, sorry, we can not take anonymous
patches, as the documentation that describes what you mean by adding the
"Signed-off-by:" line to a patch.
good luck with your legal department,
greg k-h
next prev parent reply other threads:[~2014-03-14 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:44 [PATCH] staging: android: fix coding style mourn
2014-03-13 13:50 ` Mark Einon
2014-03-13 13:54 ` Mark Einon
2014-03-13 14:13 ` mourn
2014-03-14 23:32 ` Greg KH [this message]
2014-03-14 23:38 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-09-14 0:13 [PATCH] Staging: " Sorin Facaoaru
2014-09-14 0:13 Sorin Facaoaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314233214.GA1124@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@einon.net \
--cc=mourn@2600fr.org \
--cc=rebecca@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.