[PATCH] staging: android: fix coding style

[PATCH] staging: android: fix coding style

[mourn]

From: mourn <mourn@2600fr.org>

Signed-off-by: mourn <mourn@2600fr.org>
---
 drivers/staging/android/uapi/ion.h |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index f09e7c1..6aa4956 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -27,12 +27,12 @@ typedef int ion_user_handle_t;
  * @ION_HEAP_TYPE_SYSTEM:	 memory allocated via vmalloc
  * @ION_HEAP_TYPE_SYSTEM_CONTIG: memory allocated via kmalloc
  * @ION_HEAP_TYPE_CARVEOUT:	 memory allocated from a prereserved
- * 				 carveout heap, allocations are physically
- * 				 contiguous
+ *				 carveout heap, allocations are physically
+ *				 contiguous
  * @ION_HEAP_TYPE_DMA:		 memory allocated via DMA API
  * @ION_NUM_HEAPS:		 helper for iterating over heaps, a bit mask
- * 				 is used to identify the heaps, so only 32
- * 				 total heap types are supported
+ *				 is used to identify the heaps, so only 32
+ *				 total heap types are supported
  */
 enum ion_heap_type {
 	ION_HEAP_TYPE_SYSTEM,
@@ -50,7 +50,7 @@ enum ion_heap_type {
 #define ION_HEAP_CARVEOUT_MASK		(1 << ION_HEAP_TYPE_CARVEOUT)
 #define ION_HEAP_TYPE_DMA_MASK		(1 << ION_HEAP_TYPE_DMA)
 
-#define ION_NUM_HEAP_IDS		sizeof(unsigned int) * 8
+#define ION_NUM_HEAP_IDS		(sizeof(unsigned int) * 8)
 
 /**
  * allocation flags - the lower 16 bits are used by core ion, the upper 16
@@ -78,7 +78,7 @@ enum ion_heap_type {
  * @align:		required alignment of the allocation
  * @heap_id_mask:	mask of heap ids to allocate from
  * @flags:		flags passed to heap
- * @handle:		pointer that will be populated with a cookie to use to 
+ * @handle:		pointer that will be populated with a cookie to use to
  *			refer to this allocation
  *
  * Provided by userspace as an argument to the ioctl
-- 
1.7.10.4

Re: [PATCH] staging: android: fix coding style

[Mark Einon]

On Thu, Mar 13, 2014 at 10:44:55AM +0100, mourn@2600fr.org wrote:
> From: mourn <mourn@2600fr.org>
> 
> Signed-off-by: mourn <mourn@2600fr.org>
> ---
>  drivers/staging/android/uapi/ion.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

The changes look good, however you should be a bit more specific about which 

Re: [PATCH] staging: android: fix coding style

[Mark Einon]

I'll try that again...

On Thu, Mar 13, 2014 at 01:50:47PM +0000, Mark Einon wrote:
> On Thu, Mar 13, 2014 at 10:44:55AM +0100, mourn@2600fr.org wrote:
> > From: mourn <mourn@2600fr.org>
> > 
> > Signed-off-by: mourn <mourn@2600fr.org>
> > ---
> >  drivers/staging/android/uapi/ion.h |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 

The changes look good, however you should be a bit more specific about what the
fixes are, and that you used checkpatch.pl to find them (I assume).

Also, Signed-off-by: should state your full name, which I'm also assuming isn't
'mourn'. Please see Documentation/SubmittingPatches.

Cheers,

Mark

Re: [PATCH] staging: android: fix coding style

[mourn]

> The changes look good, however you should be a bit more specific about
> what the
> fixes are, and that you used checkpatch.pl to find them (I assume).
>

Yes, you are right. I can edit the commit log.

> Also, Signed-off-by: should state your full name, which I'm also assuming
> isn't
> 'mourn'. Please see Documentation/SubmittingPatches.
>

I have a bit of a problem here. Some companies forbid their employees to
openly participate in open source projects. A request to the legal
department will take around 6 months with no hope of positive result...

Thanks

Re: [PATCH] staging: android: fix coding style

[Greg KH]

On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote:
> 
> > The changes look good, however you should be a bit more specific about
> > what the
> > fixes are, and that you used checkpatch.pl to find them (I assume).
> >
> 
> Yes, you are right. I can edit the commit log.
> 
> > Also, Signed-off-by: should state your full name, which I'm also assuming
> > isn't
> > 'mourn'. Please see Documentation/SubmittingPatches.
> >
> 
> I have a bit of a problem here. Some companies forbid their employees to
> openly participate in open source projects. A request to the legal
> department will take around 6 months with no hope of positive result...

Then I can not take your patch, sorry, we can not take anonymous
patches, as the documentation that describes what you mean by adding the
"Signed-off-by:" line to a patch.

good luck with your legal department,

greg k-h

Re: [PATCH] staging: android: fix coding style

[Greg KH]

On Thu, Mar 13, 2014 at 10:44:55AM +0100, mourn@2600fr.org wrote:
> From: mourn <mourn@2600fr.org>
> 
> Signed-off-by: mourn <mourn@2600fr.org>

As said in the thread for your other thread, this patch can't be
accepted unless you use your real name, sorry.

greg k-h

[PATCH] Staging: android: fix coding style

[Sorin Facaoaru]

- add line after declaration

Signed-off-by: Sorin Facaoaru <work@sorin.cc>
---
 drivers/staging/android/sw_sync.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }
-- 
1.9.1

[PATCH] Staging: android: fix coding style

[Sorin Facaoaru]

- add line after declaration

Signed-off-by: Sorin Facaoaru <work@sorin.cc>
---
 drivers/staging/android/sync.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e02..0d37495 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
 			     unsigned long arg)
 {
 	struct sync_fence *fence = file->private_data;
+
 	switch (cmd) {
 	case SYNC_IOC_WAIT:
 		return sync_fence_ioctl_wait(fence, arg);
-- 
1.9.1