From: Josh Cartwright <joshc@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: Harini Katakam <harinik@xilinx.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
michals@xilinx.com
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
Date: Mon, 17 Mar 2014 12:59:11 -0500 [thread overview]
Message-ID: <20140317175911.GU18529@joshc.qualcomm.com> (raw)
In-Reply-To: <20140317173017.GW11706@sirena.org.uk>
On Mon, Mar 17, 2014 at 05:30:17PM +0000, Mark Brown wrote:
> On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
[..]
> > +static int __maybe_unused cdns_spi_suspend(struct device *dev)
> > +{
>
> This needs to call spi_master_suspend() as well (and similarly on
> resume).
I'm not that familiar with the SPI core, but this seems like an
inversion. Is there a reason why the SPI master class doesn't implement
suspend/resume() callbacks which handle stopping/starting the queue
automatically for all masters?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-17 17:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 12:05 [PATCH] SPI: Add driver for Cadence SPI controller Harini Katakam
2014-03-17 12:47 ` Rob Herring
[not found] ` <CAL_JsqKacetGytGUJir7ky3qOgCy-3ny1pT_Bx4eCYV2wMgcTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17 13:14 ` Mark Brown
2014-03-17 13:14 ` Mark Brown
2014-03-17 13:22 ` Michal Simek
2014-03-17 13:30 ` Geert Uytterhoeven
2014-03-17 13:54 ` Harini Katakam
[not found] ` <5326F72E.7010401-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-03-17 19:00 ` Rob Herring
2014-03-17 19:00 ` Rob Herring
2014-03-20 11:23 ` Michal Simek
2014-03-17 14:01 ` Harini Katakam
[not found] ` <1395057936-8643-1-git-send-email-harinik-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2014-03-17 17:30 ` Mark Brown
2014-03-17 17:30 ` Mark Brown
2014-03-17 17:59 ` Josh Cartwright [this message]
2014-03-17 18:14 ` Mark Brown
2014-03-18 5:22 ` Harini Katakam
[not found] ` <554ccbca-f92e-454c-90c0-b8a4ddddf3fd-p/+QeVIcf1BZbvUCbuG1mrjjLBE8jN/0@public.gmane.org>
2014-03-18 11:06 ` Mark Brown
2014-03-18 11:06 ` Mark Brown
2014-03-18 5:16 ` Harini Katakam
2014-03-18 11:04 ` Mark Brown
[not found] ` <20140318110401.GH11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-18 12:13 ` Harini Katakam
2014-03-18 12:13 ` Harini Katakam
2014-03-18 12:33 ` Mark Brown
2014-03-18 14:45 ` Harini Katakam
2014-03-18 15:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317175911.GU18529@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=harinik@xilinx.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.