From: Mark Brown <broonie@kernel.org>
To: Harini Katakam <harini.katakam@xilinx.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
Michal Simek <michals@xilinx.com>
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
Date: Tue, 18 Mar 2014 15:59:16 +0000 [thread overview]
Message-ID: <20140318155916.GD11706@sirena.org.uk> (raw)
In-Reply-To: <aa8486d2-8571-4b31-8980-78806a80e600@CH1EHSMHS031.ehs.local>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Tue, Mar 18, 2014 at 02:45:09PM +0000, Harini Katakam wrote:
> OK. I dint consider interrupt sharing.
> Do you think the following implementation would be better?
> status = IRQ_NONE;
> if (intr_status & CDNS_SPI_IXR_MODF_MASK) {
> /* Handle this interrupt here */
> status = IRQ_HANDLED;
> } else if (intr_status & CDNS_SPI_IXR_TXOW_MASK) {
> /* Handle this interrupt here */
> status = IRQ_HANDLED;
> }
> return status;
Yes, that looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-03-18 15:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 12:05 [PATCH] SPI: Add driver for Cadence SPI controller Harini Katakam
2014-03-17 12:47 ` Rob Herring
[not found] ` <CAL_JsqKacetGytGUJir7ky3qOgCy-3ny1pT_Bx4eCYV2wMgcTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17 13:14 ` Mark Brown
2014-03-17 13:14 ` Mark Brown
2014-03-17 13:22 ` Michal Simek
2014-03-17 13:30 ` Geert Uytterhoeven
2014-03-17 13:54 ` Harini Katakam
[not found] ` <5326F72E.7010401-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-03-17 19:00 ` Rob Herring
2014-03-17 19:00 ` Rob Herring
2014-03-20 11:23 ` Michal Simek
2014-03-17 14:01 ` Harini Katakam
[not found] ` <1395057936-8643-1-git-send-email-harinik-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2014-03-17 17:30 ` Mark Brown
2014-03-17 17:30 ` Mark Brown
2014-03-17 17:59 ` Josh Cartwright
2014-03-17 18:14 ` Mark Brown
2014-03-18 5:22 ` Harini Katakam
[not found] ` <554ccbca-f92e-454c-90c0-b8a4ddddf3fd-p/+QeVIcf1BZbvUCbuG1mrjjLBE8jN/0@public.gmane.org>
2014-03-18 11:06 ` Mark Brown
2014-03-18 11:06 ` Mark Brown
2014-03-18 5:16 ` Harini Katakam
2014-03-18 11:04 ` Mark Brown
[not found] ` <20140318110401.GH11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-18 12:13 ` Harini Katakam
2014-03-18 12:13 ` Harini Katakam
2014-03-18 12:33 ` Mark Brown
2014-03-18 14:45 ` Harini Katakam
2014-03-18 15:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318155916.GD11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=harini.katakam@xilinx.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.