* [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
@ 2014-02-13 16:48 Rafał Miłecki
2014-02-28 6:27 ` Rafał Miłecki
2014-03-14 21:30 ` Hauke Mehrtens
0 siblings, 2 replies; 6+ messages in thread
From: Rafał Miłecki @ 2014-02-13 16:48 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: Hauke Mehrtens, Rafał Miłecki
Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
ones too. Example:
gpio23=wombo_reset
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
Preferably this should go as a fix for 3.14. It's really trivial and
allows support for some devices that require reset by GPIO after boot.
---
arch/mips/bcm47xx/nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/bcm47xx/nvram.c b/arch/mips/bcm47xx/nvram.c
index 6decb27..2bed73a 100644
--- a/arch/mips/bcm47xx/nvram.c
+++ b/arch/mips/bcm47xx/nvram.c
@@ -196,7 +196,7 @@ int bcm47xx_nvram_gpio_pin(const char *name)
char nvram_var[10];
char buf[30];
- for (i = 0; i < 16; i++) {
+ for (i = 0; i < 32; i++) {
err = snprintf(nvram_var, sizeof(nvram_var), "gpio%i", i);
if (err <= 0)
continue;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
2014-02-13 16:48 [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin Rafał Miłecki
@ 2014-02-28 6:27 ` Rafał Miłecki
2014-03-13 15:22 ` Rafał Miłecki
2014-03-14 21:30 ` Hauke Mehrtens
1 sibling, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2014-02-28 6:27 UTC (permalink / raw)
To: linux-mips@linux-mips.org, Ralf Baechle
Cc: Hauke Mehrtens, Rafał Miłecki
2014-02-13 17:48 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
> ones too. Example:
> gpio23=wombo_reset
Ping? Guys?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
2014-02-28 6:27 ` Rafał Miłecki
@ 2014-03-13 15:22 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2014-03-13 15:22 UTC (permalink / raw)
To: linux-mips@linux-mips.org, Ralf Baechle
Cc: Hauke Mehrtens, Rafał Miłecki
2014-02-28 7:27 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
> 2014-02-13 17:48 GMT+01:00 Rafał Miłecki <zajec5@gmail.com>:
>> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
>> ones too. Example:
>> gpio23=wombo_reset
>
> Ping? Guys?
Anyone? I've posted this patch a month ago.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
2014-02-13 16:48 [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin Rafał Miłecki
2014-02-28 6:27 ` Rafał Miłecki
@ 2014-03-14 21:30 ` Hauke Mehrtens
2014-03-19 6:43 ` Rafał Miłecki
1 sibling, 1 reply; 6+ messages in thread
From: Hauke Mehrtens @ 2014-03-14 21:30 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-mips, Ralf Baechle
On 02/13/2014 05:48 PM, Rafał Miłecki wrote:
> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
> ones too. Example:
> gpio23=wombo_reset
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> Preferably this should go as a fix for 3.14. It's really trivial and
> allows support for some devices that require reset by GPIO after boot.
> ---
> arch/mips/bcm47xx/nvram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/bcm47xx/nvram.c b/arch/mips/bcm47xx/nvram.c
> index 6decb27..2bed73a 100644
> --- a/arch/mips/bcm47xx/nvram.c
> +++ b/arch/mips/bcm47xx/nvram.c
> @@ -196,7 +196,7 @@ int bcm47xx_nvram_gpio_pin(const char *name)
> char nvram_var[10];
> char buf[30];
>
> - for (i = 0; i < 16; i++) {
> + for (i = 0; i < 32; i++) {
> err = snprintf(nvram_var, sizeof(nvram_var), "gpio%i", i);
> if (err <= 0)
> continue;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
2014-03-14 21:30 ` Hauke Mehrtens
@ 2014-03-19 6:43 ` Rafał Miłecki
2014-03-19 8:47 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2014-03-19 6:43 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-mips@linux-mips.org, Ralf Baechle
2014-03-14 22:30 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
> On 02/13/2014 05:48 PM, Rafał Miłecki wrote:
>> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
>> ones too. Example:
>> gpio23=wombo_reset
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Ralf: could you get it for 3.15 at least, please?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin
2014-03-19 6:43 ` Rafał Miłecki
@ 2014-03-19 8:47 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2014-03-19 8:47 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Hauke Mehrtens, linux-mips@linux-mips.org
On Wed, Mar 19, 2014 at 07:43:17AM +0100, Rafał Miłecki wrote:
> Date: Wed, 19 Mar 2014 07:43:17 +0100
> From: Rafał Miłecki <zajec5@gmail.com>
> To: Hauke Mehrtens <hauke@hauke-m.de>
> Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Ralf Baechle
> <ralf@linux-mips.org>
> Subject: Re: [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when
> looking for a pin
> Content-Type: text/plain; charset=UTF-8
>
> 2014-03-14 22:30 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
> > On 02/13/2014 05:48 PM, Rafał Miłecki wrote:
> >> Broadcom boards support 32 GPIOs and NVRAM may have entires for higher
> >> ones too. Example:
> >> gpio23=wombo_reset
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >
> > Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
>
> Ralf: could you get it for 3.15 at least, please?
Funny, I applied your patch minutes before seeing this email.
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-19 8:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-13 16:48 [3.14 FIX][PATCH] MIPS: BCM47XX: Check all (32) GPIOs when looking for a pin Rafał Miłecki
2014-02-28 6:27 ` Rafał Miłecki
2014-03-13 15:22 ` Rafał Miłecki
2014-03-14 21:30 ` Hauke Mehrtens
2014-03-19 6:43 ` Rafał Miłecki
2014-03-19 8:47 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.