From: Thomas Graf <tgraf@suug.ch>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net 2/3] ipmr: fix mfc notification flags
Date: Thu, 20 Mar 2014 07:39:11 +0000 [thread overview]
Message-ID: <20140320073911.GD16640@casper.infradead.org> (raw)
In-Reply-To: <1395247671-9356-2-git-send-email-nicolas.dichtel@6wind.com>
On 03/19/14 at 05:47pm, Nicolas Dichtel wrote:
> Commit 8cd3ac9f9b7b ("ipmr: advertise new mfc entries via rtnl") reuses the
> function ipmr_fill_mroute() to notify mfc events.
> But this function was used only for dump and thus was always setting the
> flag NLM_F_MULTI, which is wrong in case of a single notification.
>
> Libraries like libnl will wait forever for NLMSG_DONE.
>
> CC: Thomas Graf <tgraf@suug.ch>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
LGTM
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2014-03-20 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 16:47 [PATCH net 1/3] rtnetlink: fix fdb notification flags Nicolas Dichtel
2014-03-19 16:47 ` [PATCH net 2/3] ipmr: fix mfc " Nicolas Dichtel
2014-03-20 7:39 ` Thomas Graf [this message]
2014-03-20 20:25 ` David Miller
2014-03-19 16:47 ` [PATCH net 3/3] ip6mr: " Nicolas Dichtel
2014-03-20 7:39 ` Thomas Graf
2014-03-20 20:25 ` David Miller
2014-03-20 7:38 ` [PATCH net 1/3] rtnetlink: fix fdb " Thomas Graf
2014-03-20 20:25 ` David Miller
2014-03-21 9:18 ` Nicolas Dichtel
2014-03-21 18:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320073911.GD16640@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.