All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: turn rate change failed warning into pr_debug
Date: Thu, 20 Mar 2014 17:09:30 -0700	[thread overview]
Message-ID: <20140321000930.21989.11808@quantum> (raw)
In-Reply-To: <20140305112828.GN24917@pengutronix.de>

Quoting Sascha Hauer (2014-03-05 03:28:28)
> Mike,
> 
> Any objections to this patch?

None at all. Taken into clk-next.

Thanks,
Mike

> 
> Sascha
> 
> On Thu, Jan 16, 2014 at 04:12:55PM +0100, Sascha Hauer wrote:
> > If a rate change failed it's the opportunity of the caller to handle
> > this. Do not spam the log with a message.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > ---
> >  drivers/clk/clk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 2cf2ea6..f0124d4 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> >       /* notify that we are about to change rates */
> >       fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
> >       if (fail_clk) {
> > -             pr_warn("%s: failed to set %s rate\n", __func__,
> > +             pr_debug("%s: failed to set %s rate\n", __func__,
> >                               fail_clk->name);
> >               clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
> >               ret = -EBUSY;
> > -- 
> > 1.8.5.2
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: turn rate change failed warning into pr_debug
Date: Thu, 20 Mar 2014 17:09:30 -0700	[thread overview]
Message-ID: <20140321000930.21989.11808@quantum> (raw)
In-Reply-To: <20140305112828.GN24917@pengutronix.de>

Quoting Sascha Hauer (2014-03-05 03:28:28)
> Mike,
> 
> Any objections to this patch?

None at all. Taken into clk-next.

Thanks,
Mike

> 
> Sascha
> 
> On Thu, Jan 16, 2014 at 04:12:55PM +0100, Sascha Hauer wrote:
> > If a rate change failed it's the opportunity of the caller to handle
> > this. Do not spam the log with a message.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  drivers/clk/clk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 2cf2ea6..f0124d4 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -1460,7 +1460,7 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> >       /* notify that we are about to change rates */
> >       fail_clk = clk_propagate_rate_change(top, PRE_RATE_CHANGE);
> >       if (fail_clk) {
> > -             pr_warn("%s: failed to set %s rate\n", __func__,
> > +             pr_debug("%s: failed to set %s rate\n", __func__,
> >                               fail_clk->name);
> >               clk_propagate_rate_change(top, ABORT_RATE_CHANGE);
> >               ret = -EBUSY;
> > -- 
> > 1.8.5.2
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-03-21  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 15:12 [PATCH] clk: turn rate change failed warning into pr_debug Sascha Hauer
2014-01-16 15:12 ` Sascha Hauer
2014-03-05 11:28 ` Sascha Hauer
2014-03-05 11:28   ` Sascha Hauer
2014-03-21  0:09   ` Mike Turquette [this message]
2014-03-21  0:09     ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140321000930.21989.11808@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.