From: Greg KH <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Alan Cox <alan@linux.intel.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-serial@vger.kernel.org,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] possible removal of omap-serial
Date: Thu, 20 Mar 2014 17:12:28 -0700 [thread overview]
Message-ID: <20140321001228.GA18131@kroah.com> (raw)
In-Reply-To: <20140320235210.GB26964@saruman.home>
On Thu, Mar 20, 2014 at 06:52:10PM -0500, Felipe Balbi wrote:
> Hi folks,
>
> I've been toying with the idea of removing
> drivers/tty/serial/omap-serial.c since that's, to put it bluntly, an
> ungly copy of 8250 driver.
>
> The original concern was wrt suspend/resume but I think it'd be a far
> better approach to implement runtime PM in 8250 and write a rather small
> 8250-omap.c glue (much like 8250-acorn.c or 8250-dw.c) just to get the
> OMAP-specific details out of the way.
>
> The question I have is: omap-serial.c calls the serial devnodes ttyO\d,
> instead of ttyS\d so removing omap-serial.c would have a direct impact
> in userland. I wonder if it's an acceptable "regression" considering
> we'd be able to reuse 8250 gaining proper Flow Control support, proper
> DMA support, years and years of bug-fixes, etc.
Breaking device node names is a contentious issue for serial ports, I
don't think you can do that :(
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] possible removal of omap-serial
Date: Thu, 20 Mar 2014 17:12:28 -0700 [thread overview]
Message-ID: <20140321001228.GA18131@kroah.com> (raw)
In-Reply-To: <20140320235210.GB26964@saruman.home>
On Thu, Mar 20, 2014 at 06:52:10PM -0500, Felipe Balbi wrote:
> Hi folks,
>
> I've been toying with the idea of removing
> drivers/tty/serial/omap-serial.c since that's, to put it bluntly, an
> ungly copy of 8250 driver.
>
> The original concern was wrt suspend/resume but I think it'd be a far
> better approach to implement runtime PM in 8250 and write a rather small
> 8250-omap.c glue (much like 8250-acorn.c or 8250-dw.c) just to get the
> OMAP-specific details out of the way.
>
> The question I have is: omap-serial.c calls the serial devnodes ttyO\d,
> instead of ttyS\d so removing omap-serial.c would have a direct impact
> in userland. I wonder if it's an acceptable "regression" considering
> we'd be able to reuse 8250 gaining proper Flow Control support, proper
> DMA support, years and years of bug-fixes, etc.
Breaking device node names is a contentious issue for serial ports, I
don't think you can do that :(
next prev parent reply other threads:[~2014-03-21 0:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 23:52 [RFC] possible removal of omap-serial Felipe Balbi
2014-03-20 23:52 ` Felipe Balbi
2014-03-21 0:04 ` Alan Cox
2014-03-21 0:04 ` Alan Cox
2014-03-21 0:12 ` Greg KH [this message]
2014-03-21 0:12 ` Greg KH
2014-03-21 1:35 ` Felipe Balbi
2014-03-21 1:35 ` Felipe Balbi
2014-03-21 1:37 ` Felipe Balbi
2014-03-21 1:37 ` Felipe Balbi
2014-03-21 2:36 ` Greg KH
2014-03-21 2:36 ` Greg KH
2014-03-21 2:45 ` Robert Nelson
2014-03-21 2:45 ` Robert Nelson
2014-03-21 2:52 ` Felipe Balbi
2014-03-21 2:52 ` Felipe Balbi
2014-03-21 17:10 ` Tony Lindgren
2014-03-21 17:10 ` Tony Lindgren
2014-03-21 17:36 ` Felipe Balbi
2014-03-21 17:36 ` Felipe Balbi
2014-03-21 17:44 ` Greg KH
2014-03-21 17:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321001228.GA18131@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.