From: Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
Date: Mon, 24 Mar 2014 10:45:14 +0800 [thread overview]
Message-ID: <20140324023900.GA4002@dragon> (raw)
In-Reply-To: <1395292325-8497-2-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> This adds devicetree node for VF610, and there are 8 channels
> supported.
>
> Signed-off-by: Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Reviewed-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
changes, and also be noted that my email and git addresses just got
updated [1].
> ---
> arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index acf544e..ccc6d35 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -192,6 +192,19 @@
> status = "disabled";
> };
>
> + pwm0: pwm@40038000 {
The node should be sorted in unit-address. So shouldn't it be put right
after pit node?
Shawn
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c12837220c54c8d7138a4ee4a08c1ec67b68a2
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x40038000 0x1000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clks VF610_CLK_FTM0>,
> + <&clks VF610_CLK_FTM0_EXT_SEL>,
> + <&clks VF610_CLK_FTM0_FIX_SEL>,
> + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> + status = "disabled";
> + };
> +
> wdog@4003e000 {
> compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> reg = <0x4003e000 0x1000>;
> --
> 1.8.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
Date: Mon, 24 Mar 2014 10:45:14 +0800 [thread overview]
Message-ID: <20140324023900.GA4002@dragon> (raw)
In-Reply-To: <1395292325-8497-2-git-send-email-Li.Xiubo@freescale.com>
On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> This adds devicetree node for VF610, and there are 8 channels
> supported.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Yuan Yao <yao.yuan@freescale.com>
Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
changes, and also be noted that my email and git addresses just got
updated [1].
> ---
> arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index acf544e..ccc6d35 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -192,6 +192,19 @@
> status = "disabled";
> };
>
> + pwm0: pwm@40038000 {
The node should be sorted in unit-address. So shouldn't it be put right
after pit node?
Shawn
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c12837220c54c8d7138a4ee4a08c1ec67b68a2
> + compatible = "fsl,vf610-ftm-pwm";
> + #pwm-cells = <3>;
> + reg = <0x40038000 0x1000>;
> + clock-names = "ftm_sys", "ftm_ext",
> + "ftm_fix", "ftm_cnt_clk_en";
> + clocks = <&clks VF610_CLK_FTM0>,
> + <&clks VF610_CLK_FTM0_EXT_SEL>,
> + <&clks VF610_CLK_FTM0_FIX_SEL>,
> + <&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> + status = "disabled";
> + };
> +
> wdog@4003e000 {
> compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> reg = <0x4003e000 0x1000>;
> --
> 1.8.4
>
>
next prev parent reply other threads:[~2014-03-24 2:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 5:12 [PATCH 0/3] Add DTS node for FTM PWM Xiubo Li
2014-03-20 5:12 ` Xiubo Li
2014-03-20 5:12 ` [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node Xiubo Li
2014-03-20 5:12 ` Xiubo Li
[not found] ` <1395292325-8497-2-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-24 2:45 ` Shawn Guo [this message]
2014-03-24 2:45 ` Shawn Guo
2014-03-24 2:55 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-03-24 2:55 ` Li.Xiubo
2014-03-20 5:12 ` [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node Xiubo Li
2014-03-20 5:12 ` Xiubo Li
[not found] ` <1395292325-8497-3-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-24 2:48 ` Shawn Guo
2014-03-24 2:48 ` Shawn Guo
2014-03-24 2:52 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-03-24 2:52 ` Li.Xiubo
[not found] ` <2396982097064354a789c688a96c661a-+7O3WWA3DPshjIn37xzcLOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-03-24 2:55 ` Shawn Guo
2014-03-24 2:55 ` Shawn Guo
2014-03-20 5:12 ` [PATCH 3/3] ARM: dts: vf610-twr: Enables FTM PWM device Xiubo Li
2014-03-20 5:12 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324023900.GA4002@dragon \
--to=shawn.guo-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.