All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: hughd@google.com, xemul@parallels.com, akpm@linux-foundation.org,
	gorcunov@openvz.org
Subject: [patch 3/4] mm: Dont forget to save file map softdiry bit on unmap
Date: Mon, 24 Mar 2014 16:28:41 +0400	[thread overview]
Message-ID: <20140324125926.111035579@openvz.org> (raw)
In-Reply-To: 20140324122838.490106581@openvz.org

[-- Attachment #1: mm-file-pte-softdirty-try_to_unmap_cluster --]
[-- Type: text/plain, Size: 1124 bytes --]

pte_file_mksoft_dirty operates with argument passed by
a value and returns modified result thus need to assign
@ptfile here, otherwise it's nop operation which may lead
to lose of softdirty bit.

CC: Pavel Emelyanov <xemul@parallels.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
 mm/rmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/mm/rmap.c
===================================================================
--- linux-2.6.git.orig/mm/rmap.c
+++ linux-2.6.git/mm/rmap.c
@@ -1339,7 +1339,7 @@ static int try_to_unmap_cluster(unsigned
 		if (page->index != linear_page_index(vma, address)) {
 			pte_t ptfile = pgoff_to_pte(page->index);
 			if (pte_soft_dirty(pteval))
-				pte_file_mksoft_dirty(ptfile);
+				ptfile = pte_file_mksoft_dirty(ptfile);
 			set_pte_at(mm, address, pte, ptfile);
 		}
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: hughd@google.com, xemul@parallels.com, akpm@linux-foundation.org,
	gorcunov@openvz.org
Subject: [patch 3/4] mm: Dont forget to save file map softdiry bit on unmap
Date: Mon, 24 Mar 2014 16:28:41 +0400	[thread overview]
Message-ID: <20140324125926.111035579@openvz.org> (raw)
In-Reply-To: 20140324122838.490106581@openvz.org

[-- Attachment #1: mm-file-pte-softdirty-try_to_unmap_cluster --]
[-- Type: text/plain, Size: 899 bytes --]

pte_file_mksoft_dirty operates with argument passed by
a value and returns modified result thus need to assign
@ptfile here, otherwise it's nop operation which may lead
to lose of softdirty bit.

CC: Pavel Emelyanov <xemul@parallels.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
 mm/rmap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/mm/rmap.c
===================================================================
--- linux-2.6.git.orig/mm/rmap.c
+++ linux-2.6.git/mm/rmap.c
@@ -1339,7 +1339,7 @@ static int try_to_unmap_cluster(unsigned
 		if (page->index != linear_page_index(vma, address)) {
 			pte_t ptfile = pgoff_to_pte(page->index);
 			if (pte_soft_dirty(pteval))
-				pte_file_mksoft_dirty(ptfile);
+				ptfile = pte_file_mksoft_dirty(ptfile);
 			set_pte_at(mm, address, pte, ptfile);
 		}
 


  parent reply	other threads:[~2014-03-24 12:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 12:28 [patch 0/4] mm: A few memory tracker fixes Cyrill Gorcunov
2014-03-24 12:28 ` Cyrill Gorcunov
2014-03-24 12:28 ` [patch 1/4] mm: Make freshly remapped file pages being softdirty unconditionally Cyrill Gorcunov
2014-03-24 12:28   ` Cyrill Gorcunov
2014-03-24 12:28 ` [patch 2/4] mm: Dont forget to set softdirty on file mapped fault Cyrill Gorcunov
2014-03-24 12:28   ` Cyrill Gorcunov
2014-04-14 22:27   ` Andrew Morton
2014-04-14 22:27     ` Andrew Morton
2014-04-14 22:33     ` Cyrill Gorcunov
2014-04-14 22:33       ` Cyrill Gorcunov
2014-04-14 22:38       ` Cyrill Gorcunov
2014-04-14 22:38         ` Cyrill Gorcunov
2014-04-14 22:43         ` Andrew Morton
2014-04-14 22:43           ` Andrew Morton
2014-03-24 12:28 ` Cyrill Gorcunov [this message]
2014-03-24 12:28   ` [patch 3/4] mm: Dont forget to save file map softdiry bit on unmap Cyrill Gorcunov
2014-03-24 12:28 ` [patch 4/4] mm: Clear VM_SOFTDIRTY flag inside clear_refs_write instead of clear_soft_dirty Cyrill Gorcunov
2014-03-24 12:28   ` Cyrill Gorcunov
2014-04-15 18:06   ` Andrew Morton
2014-04-15 18:06     ` Andrew Morton
2014-04-15 18:29     ` Cyrill Gorcunov
2014-04-15 18:29       ` Cyrill Gorcunov
2014-04-15 18:44       ` Andrew Morton
2014-04-15 18:44         ` Andrew Morton
2014-04-15 18:48         ` Cyrill Gorcunov
2014-04-15 18:48           ` Cyrill Gorcunov
2014-04-15 18:52           ` Andrew Morton
2014-04-15 18:52             ` Andrew Morton
2014-04-16  7:05             ` Cyrill Gorcunov
2014-04-16  7:05               ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140324125926.111035579@openvz.org \
    --to=gorcunov@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.