From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/7] clk: sunxi: Remove calls to clk_put
Date: Tue, 25 Mar 2014 08:50:59 +0100 [thread overview]
Message-ID: <20140325075059.GL5416@lukather> (raw)
In-Reply-To: <20140324215120.32624.63543@quantum>
Hi Mike,
On Mon, Mar 24, 2014 at 02:51:20PM -0700, Mike Turquette wrote:
> Quoting Maxime Ripard (2014-03-13 08:14:13)
> > Callers of clk_put must disable the clock first. This also means that as long
> > as the clock is enabled the driver should hold a reference to that clock.
> > Hence, the call to clk_put here are bogus and should be removed.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Looks good to me. There is a balanced clk_put in the module remove
> function?
Actually, this is not part of any module, it's part of the function
called through CLK_OF_DECLARE, so there's never a remove function for
this code.
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140325/56e1f89c/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Emilio Lopez <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v5 1/7] clk: sunxi: Remove calls to clk_put
Date: Tue, 25 Mar 2014 08:50:59 +0100 [thread overview]
Message-ID: <20140325075059.GL5416@lukather> (raw)
In-Reply-To: <20140324215120.32624.63543@quantum>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hi Mike,
On Mon, Mar 24, 2014 at 02:51:20PM -0700, Mike Turquette wrote:
> Quoting Maxime Ripard (2014-03-13 08:14:13)
> > Callers of clk_put must disable the clock first. This also means that as long
> > as the clock is enabled the driver should hold a reference to that clock.
> > Hence, the call to clk_put here are bogus and should be removed.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>
> Looks good to me. There is a balanced clk_put in the module remove
> function?
Actually, this is not part of any module, it's part of the function
called through CLK_OF_DECLARE, so there's never a remove function for
this code.
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Emilio Lopez <emilio@elopez.com.ar>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-sunxi@googlegroups.com, kevin.z.m.zh@gmail.com,
sunny@allwinnertech.com, shuge@allwinnertech.com,
zhuzhenhua@allwinnertech.com, andriy.shevchenko@intel.com
Subject: Re: [PATCH v5 1/7] clk: sunxi: Remove calls to clk_put
Date: Tue, 25 Mar 2014 08:50:59 +0100 [thread overview]
Message-ID: <20140325075059.GL5416@lukather> (raw)
In-Reply-To: <20140324215120.32624.63543@quantum>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
Hi Mike,
On Mon, Mar 24, 2014 at 02:51:20PM -0700, Mike Turquette wrote:
> Quoting Maxime Ripard (2014-03-13 08:14:13)
> > Callers of clk_put must disable the clock first. This also means that as long
> > as the clock is enabled the driver should hold a reference to that clock.
> > Hence, the call to clk_put here are bogus and should be removed.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Looks good to me. There is a balanced clk_put in the module remove
> function?
Actually, this is not part of any module, it's part of the function
called through CLK_OF_DECLARE, so there's never a remove function for
this code.
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-25 7:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 15:14 [PATCH v5 0/7] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 1/7] clk: sunxi: Remove calls to clk_put Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-24 21:51 ` Mike Turquette
2014-03-24 21:51 ` Mike Turquette
2014-03-24 21:51 ` Mike Turquette
2014-03-25 7:50 ` Maxime Ripard [this message]
2014-03-25 7:50 ` Maxime Ripard
2014-03-25 7:50 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 2/7] ARM: sunxi: Split out the various machines into separate files Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 3/7] ARM: sunxi: Move the clock protection to machine hooks Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 4/7] ARM: sun6i: Protect CPU clock Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 5/7] ARM: sun6i: Protect SDRAM gating bit Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` [PATCH v5 6/7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-21 16:51 ` Arnd Bergmann
2014-03-21 16:51 ` Arnd Bergmann
2014-03-21 16:51 ` Arnd Bergmann
2014-03-13 15:14 ` [PATCH v5 7/7] ARM: sun6i: dt: Add A31 DMA controller to DTSI Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-03-13 15:14 ` Maxime Ripard
2014-04-23 12:35 ` Arnd Bergmann
2014-04-23 12:35 ` Arnd Bergmann
2014-04-23 13:10 ` Maxime Ripard
2014-04-23 13:10 ` Maxime Ripard
2014-04-23 13:10 ` Maxime Ripard
2014-03-28 15:26 ` [PATCH v5 0/7] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-03-28 15:26 ` Maxime Ripard
2014-03-28 15:26 ` Maxime Ripard
2014-04-08 8:28 ` Maxime Ripard
2014-04-08 8:28 ` Maxime Ripard
2014-04-08 8:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325075059.GL5416@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.