All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "angus.clark@st.com" <angus.clark@st.com>,
	"kernel@stlinux.com" <kernel@stlinux.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: New NAND driver
Date: Tue, 25 Mar 2014 07:59:54 +0000	[thread overview]
Message-ID: <20140325075954.GD21665@lee--X1> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAB561C@DBDE04.ent.ti.com>

Morning Pekon,

> >From: Lee Jones
> >
> >Hi Brian,
> >
> >Firstly I'd like to thank you for supporting the inclusion of ST's SPI
> >NOR (FSM) driver. As promised I will convert it over to the new
> >framework once it has been applied by your good self.
> >
> >In the meantime however, I have a NAND driver which I need to
> >submit. I wanted to give you a heads-up prior to sending it in case
> >you had any special requests. FYI: Shoving it where the sun don't
> >shine, is not a valid request by the way :). It's 2700 lines and I've
> >split it over 47 patches for reviewing purposes.
> >
> Will it be possible for you to send the patches split in one patch per file ?
> As switching back and forth, between 47 patches may be bit troublesome.
> Later you may split it as you or others like..

There is only one file. I can send it as a single patch; however, when
I sent the NOR driver [1], it was considered helpful to review in
chunks, kinda how the driver was written. I'll send it as a set to
start with and if you think it creates more problems than it solves
then we'll do something about it.

[1] https://lkml.org/lkml/2014/3/20/103

> >Sorry to do this to you Brian, I am sensitive to how over-burdened you
> >are with the subsystem already. Perhaps it might make sense to put out
> >a plea for volunteers to help with maintain MTD subsystem on LKML?
> >
> I can help reviewing those patches, if you can please share your
> controller specs, and also share if there are any already know
> hardware limitations.

Thanks for your kind offer. I will send it right away.

> >Anyway, what's the best thing to do in this instance? Should I just
> >send it to the list as an RFC and be done with it?

Kind regards,
Lee

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
	"angus.clark@st.com" <angus.clark@st.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@stlinux.com" <kernel@stlinux.com>
Subject: Re: New NAND driver
Date: Tue, 25 Mar 2014 07:59:54 +0000	[thread overview]
Message-ID: <20140325075954.GD21665@lee--X1> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAB561C@DBDE04.ent.ti.com>

Morning Pekon,

> >From: Lee Jones
> >
> >Hi Brian,
> >
> >Firstly I'd like to thank you for supporting the inclusion of ST's SPI
> >NOR (FSM) driver. As promised I will convert it over to the new
> >framework once it has been applied by your good self.
> >
> >In the meantime however, I have a NAND driver which I need to
> >submit. I wanted to give you a heads-up prior to sending it in case
> >you had any special requests. FYI: Shoving it where the sun don't
> >shine, is not a valid request by the way :). It's 2700 lines and I've
> >split it over 47 patches for reviewing purposes.
> >
> Will it be possible for you to send the patches split in one patch per file ?
> As switching back and forth, between 47 patches may be bit troublesome.
> Later you may split it as you or others like..

There is only one file. I can send it as a single patch; however, when
I sent the NOR driver [1], it was considered helpful to review in
chunks, kinda how the driver was written. I'll send it as a set to
start with and if you think it creates more problems than it solves
then we'll do something about it.

[1] https://lkml.org/lkml/2014/3/20/103

> >Sorry to do this to you Brian, I am sensitive to how over-burdened you
> >are with the subsystem already. Perhaps it might make sense to put out
> >a plea for volunteers to help with maintain MTD subsystem on LKML?
> >
> I can help reviewing those patches, if you can please share your
> controller specs, and also share if there are any already know
> hardware limitations.

Thanks for your kind offer. I will send it right away.

> >Anyway, what's the best thing to do in this instance? Should I just
> >send it to the list as an RFC and be done with it?

Kind regards,
Lee

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-03-25  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 13:24 New NAND driver Lee Jones
2014-03-24 13:24 ` Lee Jones
2014-03-24 20:39 ` Marek Vasut
2014-03-24 20:39   ` Marek Vasut
2014-03-25  6:18 ` Gupta, Pekon
2014-03-25  6:18   ` Gupta, Pekon
2014-03-25  7:59   ` Lee Jones [this message]
2014-03-25  7:59     ` Lee Jones
2014-03-25  9:49     ` Gupta, Pekon
2014-03-25  9:49       ` Gupta, Pekon
2014-03-25 10:46       ` Lee Jones
2014-03-25 10:46         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325075954.GD21665@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=angus.clark@st.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=kernel@stlinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.