From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Richard Zhu <r65037@freescale.com>,
linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Mohit Kumar <mohit.kumar@st.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver
Date: Tue, 25 Mar 2014 11:35:26 +0100 [thread overview]
Message-ID: <20140325103525.GA14789@ulmo> (raw)
In-Reply-To: <235376049.yyfljDtinu@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote:
> On Monday 24 March 2014 20:35:26 Murali Karicheri wrote:
[...]
> > +/* Keystone PCIe driver does not allow module unload */
> > +static int __init ks_pcie_init(void)
> > +{
> > + return platform_driver_probe(&ks_pcie_driver, ks_pcie_probe);
> > +}
> > +subsys_initcall(ks_pcie_init);
>
> Why subsys_initcall?
>
> We should probably try to fix unloading soon.
I did some work on this a few months ago but never got around to
cleaning up the patches. Let me see if I can resurrect that work.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver
Date: Tue, 25 Mar 2014 11:35:26 +0100 [thread overview]
Message-ID: <20140325103525.GA14789@ulmo> (raw)
In-Reply-To: <235376049.yyfljDtinu@wuerfel>
On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote:
> On Monday 24 March 2014 20:35:26 Murali Karicheri wrote:
[...]
> > +/* Keystone PCIe driver does not allow module unload */
> > +static int __init ks_pcie_init(void)
> > +{
> > + return platform_driver_probe(&ks_pcie_driver, ks_pcie_probe);
> > +}
> > +subsys_initcall(ks_pcie_init);
>
> Why subsys_initcall?
>
> We should probably try to fix unloading soon.
I did some work on this a few months ago but never got around to
cleaning up the patches. Let me see if I can resurrect that work.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140325/d2b2f628/attachment.sig>
next prev parent reply other threads:[~2014-03-25 10:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 0:35 [RESEND: RFC PATCH 0/3] Add Keystone pcie driver Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` [RESEND: RFC PATCH 2/3] pci: designware: enhancements to support keystone pcie Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` [RESEND: RFC PATCH 1/3] ARM: keystone: add pcie related options Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 0:35 ` Murali Karicheri
2014-03-25 7:44 ` Arnd Bergmann
2014-03-25 7:44 ` Arnd Bergmann
2014-03-25 7:44 ` Arnd Bergmann
2014-03-25 10:35 ` Thierry Reding [this message]
2014-03-25 10:35 ` Thierry Reding
2014-03-25 11:46 ` Andrew Murray
2014-03-25 11:46 ` Andrew Murray
[not found] ` <533C300E.7070109@ti.com>
2014-04-02 16:47 ` Andrew Murray
2014-04-02 16:47 ` Andrew Murray
2014-04-02 17:23 ` Murali Karicheri
2014-04-02 17:23 ` Murali Karicheri
2014-03-25 16:54 ` Jason Gunthorpe
2014-03-25 16:54 ` Jason Gunthorpe
2014-04-07 16:38 ` Murali Karicheri
2014-04-07 16:38 ` Murali Karicheri
2014-04-07 16:38 ` Murali Karicheri
2014-04-07 16:46 ` Jason Gunthorpe
2014-04-07 16:46 ` Jason Gunthorpe
2014-03-27 14:01 ` Karicheri, Muralidharan
2014-03-27 14:01 ` Karicheri, Muralidharan
2014-03-27 14:01 ` Karicheri, Muralidharan
2014-04-02 17:17 ` Murali Karicheri
2014-04-02 17:17 ` Murali Karicheri
2014-04-02 17:17 ` Murali Karicheri
2014-04-03 8:32 ` Lucas Stach
2014-04-03 8:32 ` Lucas Stach
2014-04-04 16:15 ` Murali Karicheri
2014-04-04 16:15 ` Murali Karicheri
2014-04-04 16:15 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325103525.GA14789@ulmo \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mohit.kumar@st.com \
--cc=r65037@freescale.com \
--cc=santosh.shilimkar@ti.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.