All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@web.de>
To: Stephen Hemminger <shemming@brocade.com>
Cc: "David Miller" <davem@davemloft.net>,
	"Linus Lüssing" <linus.luessing@web.de>,
	netdev@vger.kernel.org
Subject: Re: Multicast packets being lost (3.10 stable)
Date: Tue, 25 Mar 2014 14:06:07 +0100	[thread overview]
Message-ID: <20140325125231.GW6008@Linus-Debian> (raw)
In-Reply-To: <20140324094107.2cfbf103@nehalam.linuxnetplumber.net>

That commit is supposed to be a fix and seems to be a easily
cherry-pickable on top of 3.10. So I think it's suitable for
stable

There are two follow-up commit for this particular patch that I'm aware
of: "bridge: separate querier and query timer into IGMP/IPv4
and MLD/IPv6 ones" (cc0fdd80). That's just an optimization
and can be ignored for stable.

The second one is "bridge: don't try to update timers in case of
broken MLD queries" (248ba8ec0). Which is a direct fix for
b00589af3 and should therefore go into stable, too, if b00589af3
goes into stable.

Cheers, Linus


On Mon, Mar 24, 2014 at 09:41:07AM -0700, Stephen Hemminger wrote:
> We are seeing multicast snooping related issues.
> Is there some reason this commit never went into stable (3.10)
> 
> commit b00589af3b04736376f24625ab0b394642e89e29
> Author: Linus Lüssing <linus.luessing@web.de>
> Date:   Thu Aug 1 01:06:20 2013 +0200
> 
>     bridge: disable snooping if there is no querier
>     
>     If there is no querier on a link then we won't get periodic reports and
>     therefore won't be able to learn about multicast listeners behind ports,
>     potentially leading to lost multicast packets, especially for multicast
>     listeners that joined before the creation of the bridge.
>     
>     These lost multicast packets can appear since c5c23260594
>     ("bridge: Add multicast_querier toggle and disable queries by default")
>     in particular.
>     
>     With this patch we are flooding multicast packets if our querier is
>     disabled and if we didn't detect any other querier.
>     
>     A grace period of the Maximum Response Delay of the querier is added to
>     give multicast responses enough time to arrive and to be learned from
>     before disabling the flooding behaviour again.
>     
>     Signed-off-by: Linus Lüssing <linus.luessing@web.de>
>     Signed-off-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2014-03-25 13:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 16:41 Multicast packets being lost (3.10 stable) Stephen Hemminger
2014-03-25 13:06 ` Linus Lüssing [this message]
2014-09-10 13:33   ` [Bridge] " Linus Lüssing
2014-09-10 13:33     ` Linus Lüssing
2014-12-10 19:16     ` [Bridge] " Linus Lüssing
2014-12-10 19:16       ` Linus Lüssing
2014-12-13 20:37       ` [Bridge] " David Miller
2014-12-13 20:37         ` David Miller
2014-12-15  8:04         ` [Bridge] " Simon Horman
2014-12-15  8:04           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325125231.GW6008@Linus-Debian \
    --to=linus.luessing@web.de \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.