From: Christoph Hellwig <hch@infradead.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: JBottomley@Parallels.com, linux-scsi@vger.kernel.org,
m.lombardi85@gmail.com
Subject: Re: [PATCH] scsi: fix potential NULL pointer dereference.
Date: Tue, 25 Mar 2014 06:13:06 -0700 [thread overview]
Message-ID: <20140325131306.GA25392@infradead.org> (raw)
In-Reply-To: <1395752333-12185-1-git-send-email-mlombard@redhat.com>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 78b004d..4021849 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -2289,6 +2289,9 @@ scsi_reset_provider(struct scsi_device *dev, int flag)
> return FAILED;
>
> scmd = scsi_get_command(dev, GFP_KERNEL);
> + if (!scmd)
> + return FAILED;
> +
Fails to call scsi_autopm_put_host, or in Jame's latest tree that has
my changes put_device on the sdev gendev. I sent a correct version
earlier, but there has been very little enthusiasm for it.
next prev parent reply other threads:[~2014-03-25 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 12:58 [PATCH] scsi: fix potential NULL pointer dereference Maurizio Lombardi
2014-03-25 13:13 ` Christoph Hellwig [this message]
2014-03-25 13:30 ` Maurizio Lombardi
2014-03-25 15:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325131306.GA25392@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@Parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=m.lombardi85@gmail.com \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.