All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	JBottomley@Parallels.com, linux-scsi@vger.kernel.org,
	m.lombardi85@gmail.com
Subject: Re: [PATCH] scsi: fix potential NULL pointer dereference.
Date: Tue, 25 Mar 2014 08:26:29 -0700	[thread overview]
Message-ID: <20140325152629.GA20406@infradead.org> (raw)
In-Reply-To: <20140325133046.GD2416@dhcp-27-189.brq.redhat.com>

On Tue, Mar 25, 2014 at 02:30:46PM +0100, Maurizio Lombardi wrote:
> Yes you are right, it should call scsi_autopm_put_host before returning.
> So if you already have a correct version for it then I drop this patch.

This was the version I sent out:

http://git.infradead.org/users/hch/scsi.git/commitdiff/245e16e9091f92919c09c8bbae1d982d0717ba22

It's not correct for Jame's current tree as we also need to unwind
getting a reference on sdev_gendev now.  As there's been pushback
against the patch I didn't resubmit it yet, but now that I got my other
changes in the area in it might be worth to try again.


      reply	other threads:[~2014-03-25 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25 12:58 [PATCH] scsi: fix potential NULL pointer dereference Maurizio Lombardi
2014-03-25 13:13 ` Christoph Hellwig
2014-03-25 13:30   ` Maurizio Lombardi
2014-03-25 15:26     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325152629.GA20406@infradead.org \
    --to=hch@infradead.org \
    --cc=JBottomley@Parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=m.lombardi85@gmail.com \
    --cc=mlombard@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.