From: Dan Carpenter <dan.carpenter@oracle.com>
To: fariyaf@gmail.com
Cc: Fariya Fatima <fariyaf@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: re: rsi: Add RS9113 wireless driver
Date: Thu, 27 Mar 2014 18:05:01 +0300 [thread overview]
Message-ID: <20140327150501.GA1633@mwanda> (raw)
Hello Fariya Fatima,
The patch dad0d04fa7ba: "rsi: Add RS9113 wireless driver" from Mar
16, 2014, leads to the following static checker warning:
drivers/net/wireless/rsi/rsi_91x_mgmt.c:751 rsi_load_bootup_params()
warn: signedness bug returning '(-12)'
drivers/net/wireless/rsi/rsi_91x_mgmt.c
741 static u8 rsi_load_bootup_params(struct rsi_common *common)
742 {
743 struct sk_buff *skb;
744 struct rsi_boot_params *boot_params;
745
746 rsi_dbg(MGMT_TX_ZONE, "%s: Sending boot params frame\n", __func__);
747 skb = dev_alloc_skb(sizeof(struct rsi_boot_params));
748 if (!skb) {
749 rsi_dbg(ERR_ZONE, "%s: Failed in allocation of skb\n",
750 __func__);
751 return -ENOMEM;
^^^^^^^
This doesn't matter because the caller doesn't progate the error code
anyway. Please fix that as well.
ret = rsi_load_bootup_params(...);
if (ret)
return ret;
Instead of:
if (rsi_load_bootup_params(...))
erturn -ENOMEM;
752 }
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: fariyaf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Fariya Fatima <fariyaf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: rsi: Add RS9113 wireless driver
Date: Thu, 27 Mar 2014 18:05:01 +0300 [thread overview]
Message-ID: <20140327150501.GA1633@mwanda> (raw)
Hello Fariya Fatima,
The patch dad0d04fa7ba: "rsi: Add RS9113 wireless driver" from Mar
16, 2014, leads to the following static checker warning:
drivers/net/wireless/rsi/rsi_91x_mgmt.c:751 rsi_load_bootup_params()
warn: signedness bug returning '(-12)'
drivers/net/wireless/rsi/rsi_91x_mgmt.c
741 static u8 rsi_load_bootup_params(struct rsi_common *common)
742 {
743 struct sk_buff *skb;
744 struct rsi_boot_params *boot_params;
745
746 rsi_dbg(MGMT_TX_ZONE, "%s: Sending boot params frame\n", __func__);
747 skb = dev_alloc_skb(sizeof(struct rsi_boot_params));
748 if (!skb) {
749 rsi_dbg(ERR_ZONE, "%s: Failed in allocation of skb\n",
750 __func__);
751 return -ENOMEM;
^^^^^^^
This doesn't matter because the caller doesn't progate the error code
anyway. Please fix that as well.
ret = rsi_load_bootup_params(...);
if (ret)
return ret;
Instead of:
if (rsi_load_bootup_params(...))
erturn -ENOMEM;
752 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-03-27 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 15:05 Dan Carpenter [this message]
2014-03-27 15:05 ` rsi: Add RS9113 wireless driver Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2014-03-28 8:28 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327150501.GA1633@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fariyaf@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.