* [PATCH] qt4-embedded-gles: skip package when sgx is not set in MACHINE_FEATURES
@ 2014-03-26 19:56 Denys Dmytriyenko
2014-03-27 14:55 ` Maupin, Chase
0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2014-03-26 19:56 UTC (permalink / raw)
To: meta-arago
From: Denys Dmytriyenko <denys@ti.com>
qt4-embedded-gles depends on virtual/egl and libgles-omap3, but the latter has
strict COMPATIBLE_MACHINE setting. Latest versions of BitBake report these
missing dependencies as error during parsing, but treat as non-critical error
and proceeds with the build. Unfortunately, the return code is non-zero, even
though there were 0 build errors. One way to resolve this is to set similar
COMPATIBLE_MACHINE list for qt4-embedded-gles recipe, or check for "sgx" flag
in MACHINE_FEATURES.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
.../recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend b/meta-arago-distro/recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend
index f9e5810..e7a1dad 100644
--- a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend
+++ b/meta-arago-distro/recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend
@@ -1,3 +1,14 @@
require arago-qt4.inc
-PR := "${PR}.0"
+PR := "${PR}.1"
+
+# Some deps are missing when sgx is not set, skip this package
+python __anonymous() {
+ features = bb.data.getVar("MACHINE_FEATURES", d, 1)
+ if not features:
+ return
+ pkgn = bb.data.getVar("PN", d, 1)
+ pkgv = bb.data.getVar("PV", d, 1)
+ if "sgx" not in features:
+ raise bb.parse.SkipPackage('qt4-embedded-gles needs dependencies derived from "sgx" in MACHINE_FEATURES')
+}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qt4-embedded-gles: skip package when sgx is not set in MACHINE_FEATURES
2014-03-26 19:56 [PATCH] qt4-embedded-gles: skip package when sgx is not set in MACHINE_FEATURES Denys Dmytriyenko
@ 2014-03-27 14:55 ` Maupin, Chase
2014-03-27 15:36 ` Denys Dmytriyenko
0 siblings, 1 reply; 3+ messages in thread
From: Maupin, Chase @ 2014-03-27 14:55 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-arago@arago-project.org
>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
>Sent: Wednesday, March 26, 2014 2:57 PM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH] qt4-embedded-gles: skip package when
>sgx is not set in MACHINE_FEATURES
>
>From: Denys Dmytriyenko <denys@ti.com>
>
>qt4-embedded-gles depends on virtual/egl and libgles-omap3, but
>the latter has
>strict COMPATIBLE_MACHINE setting. Latest versions of BitBake
>report these
>missing dependencies as error during parsing, but treat as non-
>critical error
>and proceeds with the build. Unfortunately, the return code is
>non-zero, even
>though there were 0 build errors. One way to resolve this is to
>set similar
>COMPATIBLE_MACHINE list for qt4-embedded-gles recipe, or check for
>"sgx" flag
>in MACHINE_FEATURES.
>
>Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>---
> .../recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend | 13
>++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
>gles_4.8.5.bbappend b/meta-arago-distro/recipes-qt/qt4/qt4-
>embedded-gles_4.8.5.bbappend
>index f9e5810..e7a1dad 100644
>--- a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
>gles_4.8.5.bbappend
>+++ b/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
>gles_4.8.5.bbappend
>@@ -1,3 +1,14 @@
> require arago-qt4.inc
>
>-PR := "${PR}.0"
>+PR := "${PR}.1"
>+
>+# Some deps are missing when sgx is not set, skip this package
>+python __anonymous() {
>+ features = bb.data.getVar("MACHINE_FEATURES", d, 1)
>+ if not features:
>+ return
>+ pkgn = bb.data.getVar("PN", d, 1)
>+ pkgv = bb.data.getVar("PV", d, 1)
I like the solution, but what are pkgn and pkgv for? Were you planning on using these in the message below?
>+ if "sgx" not in features:
>+ raise bb.parse.SkipPackage('qt4-embedded-gles needs
>dependencies derived from "sgx" in MACHINE_FEATURES')
>+}
>--
>1.8.3.2
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qt4-embedded-gles: skip package when sgx is not set in MACHINE_FEATURES
2014-03-27 14:55 ` Maupin, Chase
@ 2014-03-27 15:36 ` Denys Dmytriyenko
0 siblings, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2014-03-27 15:36 UTC (permalink / raw)
To: Maupin, Chase; +Cc: meta-arago@arago-project.org
On Thu, Mar 27, 2014 at 02:55:05PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> >Sent: Wednesday, March 26, 2014 2:57 PM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH] qt4-embedded-gles: skip package when
> >sgx is not set in MACHINE_FEATURES
> >
> >From: Denys Dmytriyenko <denys@ti.com>
> >
> >qt4-embedded-gles depends on virtual/egl and libgles-omap3, but
> >the latter has
> >strict COMPATIBLE_MACHINE setting. Latest versions of BitBake
> >report these
> >missing dependencies as error during parsing, but treat as non-
> >critical error
> >and proceeds with the build. Unfortunately, the return code is
> >non-zero, even
> >though there were 0 build errors. One way to resolve this is to
> >set similar
> >COMPATIBLE_MACHINE list for qt4-embedded-gles recipe, or check for
> >"sgx" flag
> >in MACHINE_FEATURES.
> >
> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >---
> > .../recipes-qt/qt4/qt4-embedded-gles_4.8.5.bbappend | 13
> >++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> >diff --git a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
> >gles_4.8.5.bbappend b/meta-arago-distro/recipes-qt/qt4/qt4-
> >embedded-gles_4.8.5.bbappend
> >index f9e5810..e7a1dad 100644
> >--- a/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
> >gles_4.8.5.bbappend
> >+++ b/meta-arago-distro/recipes-qt/qt4/qt4-embedded-
> >gles_4.8.5.bbappend
> >@@ -1,3 +1,14 @@
> > require arago-qt4.inc
> >
> >-PR := "${PR}.0"
> >+PR := "${PR}.1"
> >+
> >+# Some deps are missing when sgx is not set, skip this package
> >+python __anonymous() {
> >+ features = bb.data.getVar("MACHINE_FEATURES", d, 1)
> >+ if not features:
> >+ return
> >+ pkgn = bb.data.getVar("PN", d, 1)
> >+ pkgv = bb.data.getVar("PV", d, 1)
>
> I like the solution, but what are pkgn and pkgv for? Were you planning on
> using these in the message below?
Indeed, those are leftovers from the versioned output. Don't need those now, I
will remove them.
> >+ if "sgx" not in features:
> >+ raise bb.parse.SkipPackage('qt4-embedded-gles needs
> >dependencies derived from "sgx" in MACHINE_FEATURES')
> >+}
> >--
> >1.8.3.2
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-27 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-26 19:56 [PATCH] qt4-embedded-gles: skip package when sgx is not set in MACHINE_FEATURES Denys Dmytriyenko
2014-03-27 14:55 ` Maupin, Chase
2014-03-27 15:36 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.