From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/3 v2] ASoC: tas5086: add regulator consumer support
Date: Fri, 28 Mar 2014 11:35:21 +0000 [thread overview]
Message-ID: <20140328113521.GA30768@sirena.org.uk> (raw)
In-Reply-To: <1395952936-10670-3-git-send-email-zonque@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]
On Thu, Mar 27, 2014 at 09:42:16PM +0100, Daniel Mack wrote:
> The TAS5086 has two power domains, DVDD and AVDD. Enable them both as
> long as the codec is in use.
DT binding update for this one as well please.
> While at it, move the device identification from the i2c probe to the
> codec probe, so we do it after the regulators have been enabled.
It'd be better style to enable the regulators during probe to read the
ID register rather than deferring.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-28 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 20:42 [PATCH 1/3 v2] ASoC: ak5386: add regulator consumer support Daniel Mack
2014-03-27 20:42 ` [PATCH 2/3 v2] ASoC: ak4104: " Daniel Mack
2014-03-28 11:23 ` Mark Brown
2014-03-28 11:27 ` Daniel Mack
2014-03-28 11:53 ` Mark Brown
2014-03-27 20:42 ` [PATCH 3/3 v2] ASoC: tas5086: " Daniel Mack
2014-03-28 11:35 ` Mark Brown [this message]
2014-03-28 11:40 ` Daniel Mack
2014-03-28 11:52 ` Mark Brown
2014-03-28 11:21 ` [PATCH 1/3 v2] ASoC: ak5386: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328113521.GA30768@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.