From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Sasha Levin <sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] cgroup: fix spurious lockdep warning in cgroup_exit()
Date: Sat, 29 Mar 2014 09:18:12 -0400 [thread overview]
Message-ID: <20140329131812.GC5553@htj.dyndns.org> (raw)
In-Reply-To: <53352243.80805-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, Mar 28, 2014 at 03:18:27PM +0800, Li Zefan wrote:
> cgroup_exit() is called in fork and exit path. If it's called in the
> failure path during fork, PF_EXITING isn't set, and then lockdep will
> complain.
>
> Fix this by removing cgroup_exit() in that failure path. cgroup_fork()
> does nothing that needs cleanup.
>
> Reported-by: Sasha Levin <sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied 1-2 to cgroup/for-3.15.
Thanks!
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 1/2] cgroup: fix spurious lockdep warning in cgroup_exit()
Date: Sat, 29 Mar 2014 09:18:12 -0400 [thread overview]
Message-ID: <20140329131812.GC5553@htj.dyndns.org> (raw)
In-Reply-To: <53352243.80805@huawei.com>
On Fri, Mar 28, 2014 at 03:18:27PM +0800, Li Zefan wrote:
> cgroup_exit() is called in fork and exit path. If it's called in the
> failure path during fork, PF_EXITING isn't set, and then lockdep will
> complain.
>
> Fix this by removing cgroup_exit() in that failure path. cgroup_fork()
> does nothing that needs cleanup.
>
> Reported-by: Sasha Levin <sasha.levin@oracle.com>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Applied 1-2 to cgroup/for-3.15.
Thanks!
--
tejun
next prev parent reply other threads:[~2014-03-29 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 7:18 [PATCH 1/2] cgroup: fix spurious lockdep warning in cgroup_exit() Li Zefan
2014-03-28 7:18 ` Li Zefan
[not found] ` <53352243.80805-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-03-28 7:22 ` [PATCH 2/2] cgroup: remove useless argument from cgroup_exit() Li Zefan
2014-03-28 7:22 ` Li Zefan
2014-03-29 13:18 ` Tejun Heo [this message]
2014-03-29 13:18 ` [PATCH 1/2] cgroup: fix spurious lockdep warning in cgroup_exit() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329131812.GC5553@htj.dyndns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.