Re: [PATCH v2 0/4] Allow to specify an ECC scheme through DT

[Simon Guinot <simon.guinot@sequanux.org>]

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]

On Fri, Mar 21, 2014 at 08:34:46AM -0300, Ezequiel Garcia wrote:
> Now that we have agreed on the ECC devicetree binding, here's a patchset
> that makes pxa3xx-nand driver use it.
> 
> This work is required on platforms where the flash device reports a required
> ECC strength, but that are capable of handling a stronger one. Simon Guinot
> reported a situation where the vendor provided a bootloader configured with
> a stronger than required ECC scheme. Without this patches, such a situation
> would require a hack to make the driver use a specific ECC scheme.
> 
> (Simon: it would be great if you can confirm this allows you to remove any hacks).

Hi Ezequiel,

I confirm this allows me to configure the ECC strength and step size
from DT.

Tested-by: Simon Guinot <simon.guinot@sequanux.org>

Thanks.

Simon

> 
> The first two patches clean the pxa_ecc_init(), preparing for the real
> work to be done.
> 
> The third patch makes use of the ECC strength and ECC step size parameters.
> To ensure full backward compatibility, the patch *tries* to use DT-specified
> ECC parameters, falling back to using the ONFI-specified settings if the
> former are missing.
> 
> Also, we use the ONFI 'datasheet' ECC strength requirement, to ensure the
> DT-specified ECC strength is strong enough to meet the requirement.
> 
> Finally, the last patch updates the documentation binding, with the supported
> ECC parameters.
> 
> Tested on Marvell's Armada 370 RD and also Compulab's CM-X300 (PXA3xx SoC),
> which is a non-DT platform. Based on today's l2-mtd.git.
> 
> Changes from v1:
> 
>   * Fixed typo in ECC strength normalization calculus.
> 
> Ezequiel Garcia (4):
>   mtd: nand: pxa3xx: Normalize ECC strength for ECC scheme selection
>   mtd: nand: pxa3xx: Clean pxa_ecc_init() error handling
>   mtd: nand: pxa3xx: Use ECC strength and step size devicetree binding
>   mtd: nand: pxa3xx: Add supported ECC strength and step size to the DT
>     binding
> 
>  .../devicetree/bindings/mtd/pxa3xx-nand.txt        |  8 +++
>  drivers/mtd/nand/pxa3xx_nand.c                     | 78 +++++++++++++---------
>  include/linux/platform_data/mtd-nand-pxa3xx.h      |  3 +
>  3 files changed, 59 insertions(+), 30 deletions(-)
> 
> -- 
> 1.9.0
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]