All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	alsa-devel@alsa-project.org, timur@tabi.org,
	Li.Xiubo@freescale.com
Subject: Re: [PATCH bisect 2/2] ASoC: fsl_sai: Separately enable interrupts for Tx and Rx streams
Date: Tue, 1 Apr 2014 21:21:57 +0800	[thread overview]
Message-ID: <20140401132156.GB27586@MrMyself> (raw)
In-Reply-To: <20140401120715.GR2269@sirena.org.uk>

On Tue, Apr 01, 2014 at 01:07:15PM +0100, Mark Brown wrote:
> On Tue, Apr 01, 2014 at 11:17:07AM +0800, Nicolin Chen wrote:
> > We only enable one side interrupt for each stream since over/underrun
> > on the opposite stream would be resulted from what we previously did,
> > enabling TERE but remaining FRDE disabled, even though the xrun on the
> > opposite direction will not break the current stream.
> 
> This still doesn't apply against fsl-sai (nor for-next).

Sir, I just rebased my for-next branch again and found that it's missing
two applied patches: "ASoC: fsl_sai: Add isr to deal with error flag" and
"ASoC: fsl_sai: Improve fsl_sai_isr()", so that's why this PATCH-2 could
not be applied against it as it needs the macro that's included in the
patch "ASoC: fsl_sai: Add isr to deal with error flag".

What should I do now?

Thank you,
Nicolin

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Li.Xiubo@freescale.com,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	timur@tabi.org
Subject: Re: [PATCH bisect 2/2] ASoC: fsl_sai: Separately enable interrupts for Tx and Rx streams
Date: Tue, 1 Apr 2014 21:21:57 +0800	[thread overview]
Message-ID: <20140401132156.GB27586@MrMyself> (raw)
In-Reply-To: <20140401120715.GR2269@sirena.org.uk>

On Tue, Apr 01, 2014 at 01:07:15PM +0100, Mark Brown wrote:
> On Tue, Apr 01, 2014 at 11:17:07AM +0800, Nicolin Chen wrote:
> > We only enable one side interrupt for each stream since over/underrun
> > on the opposite stream would be resulted from what we previously did,
> > enabling TERE but remaining FRDE disabled, even though the xrun on the
> > opposite direction will not break the current stream.
> 
> This still doesn't apply against fsl-sai (nor for-next).

Sir, I just rebased my for-next branch again and found that it's missing
two applied patches: "ASoC: fsl_sai: Add isr to deal with error flag" and
"ASoC: fsl_sai: Improve fsl_sai_isr()", so that's why this PATCH-2 could
not be applied against it as it needs the macro that's included in the
patch "ASoC: fsl_sai: Add isr to deal with error flag".

What should I do now?

Thank you,
Nicolin

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
	<alsa-devel@alsa-project.org>, <timur@tabi.org>,
	<Li.Xiubo@freescale.com>
Subject: Re: [PATCH bisect 2/2] ASoC: fsl_sai: Separately enable interrupts for Tx and Rx streams
Date: Tue, 1 Apr 2014 21:21:57 +0800	[thread overview]
Message-ID: <20140401132156.GB27586@MrMyself> (raw)
In-Reply-To: <20140401120715.GR2269@sirena.org.uk>

On Tue, Apr 01, 2014 at 01:07:15PM +0100, Mark Brown wrote:
> On Tue, Apr 01, 2014 at 11:17:07AM +0800, Nicolin Chen wrote:
> > We only enable one side interrupt for each stream since over/underrun
> > on the opposite stream would be resulted from what we previously did,
> > enabling TERE but remaining FRDE disabled, even though the xrun on the
> > opposite direction will not break the current stream.
> 
> This still doesn't apply against fsl-sai (nor for-next).

Sir, I just rebased my for-next branch again and found that it's missing
two applied patches: "ASoC: fsl_sai: Add isr to deal with error flag" and
"ASoC: fsl_sai: Improve fsl_sai_isr()", so that's why this PATCH-2 could
not be applied against it as it needs the macro that's included in the
patch "ASoC: fsl_sai: Add isr to deal with error flag".

What should I do now?

Thank you,
Nicolin


  reply	other threads:[~2014-04-01 13:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01  3:17 [PATCH bisect 0/2] ASoC: fsl_sai: Overwrite trigger() Nicolin Chen
2014-04-01  3:17 ` Nicolin Chen
2014-04-01  3:17 ` Nicolin Chen
2014-04-01  3:17 ` [PATCH bisect 1/2] ASoC: fsl_sai: Fix buggy configurations in trigger() Nicolin Chen
2014-04-01  3:17   ` Nicolin Chen
2014-04-01  3:17   ` Nicolin Chen
2014-04-01 11:56   ` Mark Brown
2014-04-01 11:56     ` Mark Brown
2014-04-01  3:17 ` [PATCH bisect 2/2] ASoC: fsl_sai: Separately enable interrupts for Tx and Rx streams Nicolin Chen
2014-04-01  3:17   ` Nicolin Chen
2014-04-01  3:17   ` Nicolin Chen
2014-04-01  3:25   ` Dongsheng.Wang
2014-04-01  3:25     ` Dongsheng.Wang
2014-04-01  3:25     ` Dongsheng.Wang
2014-04-01  3:14     ` Nicolin Chen
2014-04-01  3:14       ` Nicolin Chen
2014-04-01  3:48       ` Dongsheng.Wang
2014-04-01  3:48         ` Dongsheng.Wang
2014-04-01  3:48         ` Dongsheng.Wang
2014-04-01  3:37         ` Nicolin Chen
2014-04-01  3:37           ` Nicolin Chen
2014-04-01  4:19           ` Dongsheng.Wang
2014-04-01  4:19             ` Dongsheng.Wang
2014-04-01 12:07   ` Mark Brown
2014-04-01 12:07     ` Mark Brown
2014-04-01 13:21     ` Nicolin Chen [this message]
2014-04-01 13:21       ` Nicolin Chen
2014-04-01 13:21       ` Nicolin Chen
2014-04-01 16:42       ` Mark Brown
2014-04-01 16:42         ` Mark Brown
2014-04-02  2:18         ` Nicolin Chen
2014-04-02  2:18           ` Nicolin Chen
2014-04-02  2:18           ` Nicolin Chen
2014-04-01 11:04 ` [PATCH bisect 0/2] ASoC: fsl_sai: Overwrite trigger() Mark Brown
2014-04-01 11:04   ` Mark Brown
2014-04-01 10:54   ` Nicolin Chen
2014-04-01 10:54     ` Nicolin Chen
2014-04-01 10:54     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140401132156.GB27586@MrMyself \
    --to=guangyu.chen@freescale.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.