From: Dan Carpenter <dan.carpenter@oracle.com>
To: Byungho An <bh74.an@samsung.com>
Cc: Girish K S <ks.giri@samsung.com>,
Siva Reddy Kallam <siva.kallam@samsung.com>,
Vipul Pandya <vipul.pandya@samsung.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 3/3] net: sxgbe: make "core_ops" static
Date: Tue, 01 Apr 2014 13:39:18 +0000 [thread overview]
Message-ID: <20140401133918.GA11087@mwanda> (raw)
The "core_ops" variable isn't referenced outside this file and Sparse
complains about it:
drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c:239:29: warning:
symbol 'core_ops' was not declared. Should it be static?
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
index 2e11da0..c4da7a2 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
@@ -236,7 +236,7 @@ static void sxgbe_disable_rx_csum(void __iomem *ioaddr)
writel(ctrl, ioaddr + SXGBE_CORE_RX_CONFIG_REG);
}
-const struct sxgbe_core_ops core_ops = {
+static const struct sxgbe_core_ops core_ops = {
.core_init = sxgbe_core_init,
.dump_regs = sxgbe_core_dump_regs,
.host_irq_status = sxgbe_core_host_irq_status,
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Byungho An <bh74.an@samsung.com>
Cc: Girish K S <ks.giri@samsung.com>,
Siva Reddy Kallam <siva.kallam@samsung.com>,
Vipul Pandya <vipul.pandya@samsung.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 3/3] net: sxgbe: make "core_ops" static
Date: Tue, 1 Apr 2014 16:39:18 +0300 [thread overview]
Message-ID: <20140401133918.GA11087@mwanda> (raw)
The "core_ops" variable isn't referenced outside this file and Sparse
complains about it:
drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c:239:29: warning:
symbol 'core_ops' was not declared. Should it be static?
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
index 2e11da0..c4da7a2 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c
@@ -236,7 +236,7 @@ static void sxgbe_disable_rx_csum(void __iomem *ioaddr)
writel(ctrl, ioaddr + SXGBE_CORE_RX_CONFIG_REG);
}
-const struct sxgbe_core_ops core_ops = {
+static const struct sxgbe_core_ops core_ops = {
.core_init = sxgbe_core_init,
.dump_regs = sxgbe_core_dump_regs,
.host_irq_status = sxgbe_core_host_irq_status,
next reply other threads:[~2014-04-01 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 13:39 Dan Carpenter [this message]
2014-04-01 13:39 ` [patch 3/3] net: sxgbe: make "core_ops" static Dan Carpenter
2014-04-01 20:27 ` David Miller
2014-04-01 20:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401133918.GA11087@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bh74.an@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ks.giri@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=siva.kallam@samsung.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.