* [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
@ 2014-04-02 23:17 Sherif Shehab Aldin
2014-04-02 23:21 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Sherif Shehab Aldin @ 2014-04-02 23:17 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, silentquote, Sherif Shehab Aldin
Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 52 ++++++++++++++++-----------------
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5b8b094..4c828c2 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -642,9 +642,9 @@ usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp,
result->resp1 = le16_to_cpu(cmdresp->resp1);
result->resp2 = le16_to_cpu(cmdresp->resp2);
- pr_debug("cmdresult:status=0x%04x "
- "resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
- result->status, result->resp0, result->resp1, result->resp2);
+ pr_debug("cmdresult:status=0x%04x resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
+ result->status, result->resp0,
+ result->resp1, result->resp2);
return result->status & HFA384x_STATUS_RESULT;
}
@@ -991,9 +991,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
result = hfa384x_docmd_wait(hw, &cmd);
- pr_debug("cmdresp.init: "
- "status=0x%04x, resp0=0x%04x, "
- "resp1=0x%04x, resp2=0x%04x\n",
+ pr_debug("cmdresp.init: status=0x%04x, resp0=0x%04x, resp1=0x%04x, resp2=0x%04x\n",
cmd.result.status,
cmd.result.resp0, cmd.result.resp1, cmd.result.resp2);
if (result == 0) {
@@ -1381,9 +1379,8 @@ hfa384x_docmd(hfa384x_t *hw,
ctlx->outbufsize = sizeof(ctlx->outbuf.cmdreq);
- pr_debug("cmdreq: cmd=0x%04x "
- "parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
- cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
+ pr_debug("cmdreq: cmd=0x%04x parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
+ cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
ctlx->reapable = mode;
ctlx->cmdcb = cmdcb;
@@ -2018,7 +2015,8 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
if (hw->dlstate != HFA384x_DLSTATE_FLASHENABLED)
return -EINVAL;
- netdev_info(hw->wlandev->netdev, "Download %d bytes to flash @0x%06x\n", len, daddr);
+ netdev_info(hw->wlandev->netdev,
+ "Download %d bytes to flash @0x%06x\n", len, daddr);
/* Convert to flat address for arithmetic */
/* NOTE: dlbuffer RID stores the address in AUX format */
@@ -2028,8 +2026,9 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
hw->bufinfo.page, hw->bufinfo.offset, dlbufaddr);
#if 0
- netdev_warn(hw->wlandev->netdev, "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
- hw->bufinfo.len, hw->dltimeout);
+ netdev_warn(hw->wlandev->netdev,
+ "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
+ hw->bufinfo.len, hw->dltimeout);
#endif
/* Calculations to determine how many fills of the dlbuffer to do
* and how many USB wmemreq's to do for each fill. At this point
@@ -2062,9 +2061,9 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
result = hfa384x_cmd_download(hw, HFA384x_PROGMODE_NV,
burnlo, burnhi, burnlen);
if (result) {
- netdev_err(hw->wlandev->netdev, "download(NV,lo=%x,hi=%x,len=%x) "
- "cmd failed, result=%d. Aborting d/l\n",
- burnlo, burnhi, burnlen, result);
+ netdev_err(hw->wlandev->netdev,
+ "download(NV,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
+ burnlo, burnhi, burnlen, result);
goto exit_proc;
}
@@ -2095,8 +2094,7 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
0, 0, 0);
if (result) {
netdev_err(hw->wlandev->netdev,
- "download(NVWRITE,lo=%x,hi=%x,len=%x) "
- "cmd failed, result=%d. Aborting d/l\n",
+ "download(NVWRITE,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
burnlo, burnhi, burnlen, result);
goto exit_proc;
}
@@ -2352,7 +2350,8 @@ int hfa384x_drvr_ramdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
if (hw->dlstate != HFA384x_DLSTATE_RAMENABLED)
return -EINVAL;
- netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n", len, daddr);
+ netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n",
+ len, daddr);
/* How many dowmem calls? */
nwrites = len / HFA384x_USB_RWMEM_MAXLEN;
@@ -2462,7 +2461,8 @@ int hfa384x_drvr_readpda(hfa384x_t *hw, void *buf, unsigned int len)
pdrcode = le16_to_cpu(pda[currpdr + 1]);
/* Test the record length */
if (pdrlen > HFA384x_PDR_LEN_MAX || pdrlen == 0) {
- netdev_err(hw->wlandev->netdev, "pdrlen invalid=%d\n", pdrlen);
+ netdev_err(hw->wlandev->netdev,
+ "pdrlen invalid=%d\n", pdrlen);
pdaok = 0;
break;
}
@@ -2784,7 +2784,8 @@ int hfa384x_drvr_txframe(hfa384x_t *hw, struct sk_buff *skb,
result = 1;
ret = submit_tx_urb(hw, &hw->tx_urb, GFP_ATOMIC);
if (ret != 0) {
- netdev_err(hw->wlandev->netdev, "submit_tx_urb() failed, error=%d\n", ret);
+ netdev_err(hw->wlandev->netdev,
+ "submit_tx_urb() failed, error=%d\n", ret);
result = 3;
}
@@ -3397,8 +3398,7 @@ retry:
* Throw this CTLX away ...
*/
netdev_err(hw->wlandev->netdev,
- "Matched IN URB, CTLX[%d] in invalid state(%s)."
- " Discarded.\n",
+ "Matched IN URB, CTLX[%d] in invalid state(%s). Discarded.\n",
le16_to_cpu(ctlx->outbuf.type),
ctlxstr(ctlx->state));
if (unlocked_usbctlx_cancel_async(hw, ctlx) == 0)
@@ -4139,13 +4139,13 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
default:
if (pdrcode < 0x1000) {
/* code is OK, but we don't know exactly what it is */
- pr_debug("Encountered unknown PDR#=0x%04x, "
- "assuming it's ok.\n", pdrcode);
+ pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
+ pdrcode);
return 1;
} else {
/* bad code */
- pr_debug("Encountered unknown PDR#=0x%04x, "
- "(>=0x1000), assuming it's bad.\n", pdrcode);
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+ pdrcode);
return 0;
}
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
2014-04-02 23:17 [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule Sherif Shehab Aldin
@ 2014-04-02 23:21 ` Joe Perches
2014-04-02 23:37 ` Sherif
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2014-04-02 23:21 UTC (permalink / raw)
To: Sherif Shehab Aldin; +Cc: gregkh, devel, linux-kernel, silentquote
On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote:
> Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Please use "scripts/checkpatch.pl --strict" on patches
to files in drivers/staging.
CHECK: Alignment should match open parenthesis
#75: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:646:
+ pr_debug("cmdresult:status=0x%04x resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
+ result->status, result->resp0,
CHECK: Alignment should match open parenthesis
#99: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:1383:
+ pr_debug("cmdreq: cmd=0x%04x parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
+ cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
CHECK: Alignment should match open parenthesis
#109: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2019:
+ netdev_info(hw->wlandev->netdev,
+ "Download %d bytes to flash @0x%06x\n", len, daddr);
CHECK: Alignment should match open parenthesis
#120: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2030:
+ netdev_warn(hw->wlandev->netdev,
+ "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
CHECK: Alignment should match open parenthesis
#133: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2065:
+ netdev_err(hw->wlandev->netdev,
+ "download(NV,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
CHECK: Alignment should match open parenthesis
#154: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2354:
+ netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n",
+ len, daddr);
CHECK: Alignment should match open parenthesis
#164: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2465:
+ netdev_err(hw->wlandev->netdev,
+ "pdrlen invalid=%d\n", pdrlen);
CHECK: Alignment should match open parenthesis
#174: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2788:
+ netdev_err(hw->wlandev->netdev,
+ "submit_tx_urb() failed, error=%d\n", ret);
CHECK: Alignment should match open parenthesis
#195: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4143:
+ pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
+ pdrcode);
CHECK: Alignment should match open parenthesis
#202: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4148:
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+ pdrcode);
total: 0 errors, 2 warnings, 10 checks, 127 lines checked
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
@ 2014-04-02 23:32 Sherif Shehab Aldin
0 siblings, 0 replies; 7+ messages in thread
From: Sherif Shehab Aldin @ 2014-04-02 23:32 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, silentquote, Sherif Shehab Aldin
Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 52 ++++++++++++++++-----------------
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 5b8b094..4c828c2 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -642,9 +642,9 @@ usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp,
result->resp1 = le16_to_cpu(cmdresp->resp1);
result->resp2 = le16_to_cpu(cmdresp->resp2);
- pr_debug("cmdresult:status=0x%04x "
- "resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
- result->status, result->resp0, result->resp1, result->resp2);
+ pr_debug("cmdresult:status=0x%04x resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
+ result->status, result->resp0,
+ result->resp1, result->resp2);
return result->status & HFA384x_STATUS_RESULT;
}
@@ -991,9 +991,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
result = hfa384x_docmd_wait(hw, &cmd);
- pr_debug("cmdresp.init: "
- "status=0x%04x, resp0=0x%04x, "
- "resp1=0x%04x, resp2=0x%04x\n",
+ pr_debug("cmdresp.init: status=0x%04x, resp0=0x%04x, resp1=0x%04x, resp2=0x%04x\n",
cmd.result.status,
cmd.result.resp0, cmd.result.resp1, cmd.result.resp2);
if (result == 0) {
@@ -1381,9 +1379,8 @@ hfa384x_docmd(hfa384x_t *hw,
ctlx->outbufsize = sizeof(ctlx->outbuf.cmdreq);
- pr_debug("cmdreq: cmd=0x%04x "
- "parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
- cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
+ pr_debug("cmdreq: cmd=0x%04x parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
+ cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
ctlx->reapable = mode;
ctlx->cmdcb = cmdcb;
@@ -2018,7 +2015,8 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
if (hw->dlstate != HFA384x_DLSTATE_FLASHENABLED)
return -EINVAL;
- netdev_info(hw->wlandev->netdev, "Download %d bytes to flash @0x%06x\n", len, daddr);
+ netdev_info(hw->wlandev->netdev,
+ "Download %d bytes to flash @0x%06x\n", len, daddr);
/* Convert to flat address for arithmetic */
/* NOTE: dlbuffer RID stores the address in AUX format */
@@ -2028,8 +2026,9 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
hw->bufinfo.page, hw->bufinfo.offset, dlbufaddr);
#if 0
- netdev_warn(hw->wlandev->netdev, "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
- hw->bufinfo.len, hw->dltimeout);
+ netdev_warn(hw->wlandev->netdev,
+ "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
+ hw->bufinfo.len, hw->dltimeout);
#endif
/* Calculations to determine how many fills of the dlbuffer to do
* and how many USB wmemreq's to do for each fill. At this point
@@ -2062,9 +2061,9 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
result = hfa384x_cmd_download(hw, HFA384x_PROGMODE_NV,
burnlo, burnhi, burnlen);
if (result) {
- netdev_err(hw->wlandev->netdev, "download(NV,lo=%x,hi=%x,len=%x) "
- "cmd failed, result=%d. Aborting d/l\n",
- burnlo, burnhi, burnlen, result);
+ netdev_err(hw->wlandev->netdev,
+ "download(NV,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
+ burnlo, burnhi, burnlen, result);
goto exit_proc;
}
@@ -2095,8 +2094,7 @@ int hfa384x_drvr_flashdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
0, 0, 0);
if (result) {
netdev_err(hw->wlandev->netdev,
- "download(NVWRITE,lo=%x,hi=%x,len=%x) "
- "cmd failed, result=%d. Aborting d/l\n",
+ "download(NVWRITE,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
burnlo, burnhi, burnlen, result);
goto exit_proc;
}
@@ -2352,7 +2350,8 @@ int hfa384x_drvr_ramdl_write(hfa384x_t *hw, u32 daddr, void *buf, u32 len)
if (hw->dlstate != HFA384x_DLSTATE_RAMENABLED)
return -EINVAL;
- netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n", len, daddr);
+ netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n",
+ len, daddr);
/* How many dowmem calls? */
nwrites = len / HFA384x_USB_RWMEM_MAXLEN;
@@ -2462,7 +2461,8 @@ int hfa384x_drvr_readpda(hfa384x_t *hw, void *buf, unsigned int len)
pdrcode = le16_to_cpu(pda[currpdr + 1]);
/* Test the record length */
if (pdrlen > HFA384x_PDR_LEN_MAX || pdrlen == 0) {
- netdev_err(hw->wlandev->netdev, "pdrlen invalid=%d\n", pdrlen);
+ netdev_err(hw->wlandev->netdev,
+ "pdrlen invalid=%d\n", pdrlen);
pdaok = 0;
break;
}
@@ -2784,7 +2784,8 @@ int hfa384x_drvr_txframe(hfa384x_t *hw, struct sk_buff *skb,
result = 1;
ret = submit_tx_urb(hw, &hw->tx_urb, GFP_ATOMIC);
if (ret != 0) {
- netdev_err(hw->wlandev->netdev, "submit_tx_urb() failed, error=%d\n", ret);
+ netdev_err(hw->wlandev->netdev,
+ "submit_tx_urb() failed, error=%d\n", ret);
result = 3;
}
@@ -3397,8 +3398,7 @@ retry:
* Throw this CTLX away ...
*/
netdev_err(hw->wlandev->netdev,
- "Matched IN URB, CTLX[%d] in invalid state(%s)."
- " Discarded.\n",
+ "Matched IN URB, CTLX[%d] in invalid state(%s). Discarded.\n",
le16_to_cpu(ctlx->outbuf.type),
ctlxstr(ctlx->state));
if (unlocked_usbctlx_cancel_async(hw, ctlx) == 0)
@@ -4139,13 +4139,13 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
default:
if (pdrcode < 0x1000) {
/* code is OK, but we don't know exactly what it is */
- pr_debug("Encountered unknown PDR#=0x%04x, "
- "assuming it's ok.\n", pdrcode);
+ pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
+ pdrcode);
return 1;
} else {
/* bad code */
- pr_debug("Encountered unknown PDR#=0x%04x, "
- "(>=0x1000), assuming it's bad.\n", pdrcode);
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+ pdrcode);
return 0;
}
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
2014-04-02 23:21 ` Joe Perches
@ 2014-04-02 23:37 ` Sherif
2014-04-02 23:40 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Sherif @ 2014-04-02 23:37 UTC (permalink / raw)
To: Joe Perches, Sherif Shehab Aldin; +Cc: devel, linux-kernel
done and sent in a new mail.
BTW regarding "Alignment should match open parenthesis" rule, It's
missing from Documentation/CodingStyle
On 04/03/2014 01:21 AM, Joe Perches wrote:
> On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote:
>> Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c
>
> Please use "scripts/checkpatch.pl --strict" on patches
> to files in drivers/staging.
>
> CHECK: Alignment should match open parenthesis
> #75: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:646:
> + pr_debug("cmdresult:status=0x%04x resp0=0x%04x resp1=0x%04x resp2=0x%04x\n",
> + result->status, result->resp0,
>
> CHECK: Alignment should match open parenthesis
> #99: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:1383:
> + pr_debug("cmdreq: cmd=0x%04x parm0=0x%04x parm1=0x%04x parm2=0x%04x\n",
> + cmd->cmd, cmd->parm0, cmd->parm1, cmd->parm2);
>
> CHECK: Alignment should match open parenthesis
> #109: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2019:
> + netdev_info(hw->wlandev->netdev,
> + "Download %d bytes to flash @0x%06x\n", len, daddr);
>
> CHECK: Alignment should match open parenthesis
> #120: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2030:
> + netdev_warn(hw->wlandev->netdev,
> + "dlbuf@0x%06lx len=%d to=%d\n", dlbufaddr,
>
> CHECK: Alignment should match open parenthesis
> #133: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2065:
> + netdev_err(hw->wlandev->netdev,
> + "download(NV,lo=%x,hi=%x,len=%x) cmd failed, result=%d. Aborting d/l\n",
>
> CHECK: Alignment should match open parenthesis
> #154: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2354:
> + netdev_info(hw->wlandev->netdev, "Writing %d bytes to ram @0x%06x\n",
> + len, daddr);
>
> CHECK: Alignment should match open parenthesis
> #164: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2465:
> + netdev_err(hw->wlandev->netdev,
> + "pdrlen invalid=%d\n", pdrlen);
>
> CHECK: Alignment should match open parenthesis
> #174: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:2788:
> + netdev_err(hw->wlandev->netdev,
> + "submit_tx_urb() failed, error=%d\n", ret);
>
> CHECK: Alignment should match open parenthesis
> #195: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4143:
> + pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
> + pdrcode);
>
> CHECK: Alignment should match open parenthesis
> #202: FILE: drivers/staging/wlan-ng/hfa384x_usb.c:4148:
> + pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
> + pdrcode);
>
> total: 0 errors, 2 warnings, 10 checks, 127 lines checked
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
2014-04-02 23:37 ` Sherif
@ 2014-04-02 23:40 ` Joe Perches
2014-04-02 23:48 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2014-04-02 23:40 UTC (permalink / raw)
To: Sherif, Greg KH; +Cc: Sherif Shehab Aldin, devel, linux-kernel
On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote:
> BTW regarding "Alignment should match open parenthesis" rule, It's
> missing from Documentation/CodingStyle
It's "maintainer's preference" in at least
net/, drivers/net and drivers/staging.
Maybe it's true for drivers/usb too.
Greg?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
2014-04-02 23:40 ` Joe Perches
@ 2014-04-02 23:48 ` Greg KH
2014-04-02 23:55 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2014-04-02 23:48 UTC (permalink / raw)
To: Joe Perches; +Cc: Sherif, Sherif Shehab Aldin, devel, linux-kernel
On Wed, Apr 02, 2014 at 04:40:38PM -0700, Joe Perches wrote:
> On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote:
> > BTW regarding "Alignment should match open parenthesis" rule, It's
> > missing from Documentation/CodingStyle
>
> It's "maintainer's preference" in at least
> net/, drivers/net and drivers/staging.
>
> Maybe it's true for drivers/usb too.
>
> Greg?
Yes, I "prefer" that as well, but if that's the only thing wrong with
the code, I really don't care.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule
2014-04-02 23:48 ` Greg KH
@ 2014-04-02 23:55 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2014-04-02 23:55 UTC (permalink / raw)
To: Greg KH; +Cc: Sherif, Sherif Shehab Aldin, devel, linux-kernel
On Wed, 2014-04-02 at 16:48 -0700, Greg KH wrote:
> On Wed, Apr 02, 2014 at 04:40:38PM -0700, Joe Perches wrote:
> > On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote:
> > > BTW regarding "Alignment should match open parenthesis" rule, It's
> > > missing from Documentation/CodingStyle
> >
> > It's "maintainer's preference" in at least
> > net/, drivers/net and drivers/staging.
> >
> > Maybe it's true for drivers/usb too.
> >
> > Greg?
>
> Yes, I "prefer" that as well, but if that's the only thing wrong with
> the code, I really don't care.
I generally don't care much either, but this patch was
also changing lines from the preferred indentation style
to something else.
cheers, Joe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-02 23:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 23:17 [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule Sherif Shehab Aldin
2014-04-02 23:21 ` Joe Perches
2014-04-02 23:37 ` Sherif
2014-04-02 23:40 ` Joe Perches
2014-04-02 23:48 ` Greg KH
2014-04-02 23:55 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2014-04-02 23:32 Sherif Shehab Aldin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.