From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, pawel.moll@arm.com,
linux-doc@vger.kernel.org, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org, robh+dt@kernel.org, timur@tabi.org,
Li.Xiubo@freescale.com, rob@landley.net, galak@codeaurora.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_sai: Add imx6sx platform support
Date: Thu, 3 Apr 2014 11:11:18 +0800 [thread overview]
Message-ID: <20140403031116.GA31246@MrMyself> (raw)
In-Reply-To: <20140402195208.GM14763@sirena.org.uk>
On Wed, Apr 02, 2014 at 08:52:08PM +0100, Mark Brown wrote:
> On Tue, Apr 01, 2014 at 07:34:09PM +0800, Nicolin Chen wrote:
> > The next coming i.MX6 Solo X SoC also contains SAI module while we use
> > imp_pcm_init() for i.MX platform.
>
> I've applied this, though obviously it'd be better if we had dmaengine
> support for this SoC so that it was just a compatible string update and
> didn't require any code.
Hmm...actually imx_pcm_init() is just a shell calling dmaengine while it
has its own config and flags. So we still need to extinguish these two
elements for them even if using devm_snd_dmaengine_pcm_register() eventually.
But the idea to merge them into one entry should be great for 3rd platform
or even further one. And a patch for imx-pcm-dma and all callers of it
would be needed then.
Thank you,
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<alsa-devel@alsa-project.org>, <timur@tabi.org>,
<Li.Xiubo@freescale.com>, <linux-doc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <rob@landley.net>,
<galak@codeaurora.org>, <ijc+devicetree@hellion.org.uk>,
<mark.rutland@arm.com>, <pawel.moll@arm.com>,
<robh+dt@kernel.org>
Subject: Re: [PATCH] ASoC: fsl_sai: Add imx6sx platform support
Date: Thu, 3 Apr 2014 11:11:18 +0800 [thread overview]
Message-ID: <20140403031116.GA31246@MrMyself> (raw)
In-Reply-To: <20140402195208.GM14763@sirena.org.uk>
On Wed, Apr 02, 2014 at 08:52:08PM +0100, Mark Brown wrote:
> On Tue, Apr 01, 2014 at 07:34:09PM +0800, Nicolin Chen wrote:
> > The next coming i.MX6 Solo X SoC also contains SAI module while we use
> > imp_pcm_init() for i.MX platform.
>
> I've applied this, though obviously it'd be better if we had dmaengine
> support for this SoC so that it was just a compatible string update and
> didn't require any code.
Hmm...actually imx_pcm_init() is just a shell calling dmaengine while it
has its own config and flags. So we still need to extinguish these two
elements for them even if using devm_snd_dmaengine_pcm_register() eventually.
But the idea to merge them into one entry should be great for 3rd platform
or even further one. And a patch for imx-pcm-dma and all callers of it
would be needed then.
Thank you,
Nicolin
next prev parent reply other threads:[~2014-04-03 3:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 11:34 [PATCH] ASoC: fsl_sai: Add imx6sx platform support Nicolin Chen
2014-04-01 11:34 ` Nicolin Chen
2014-04-01 11:34 ` Nicolin Chen
2014-04-02 19:52 ` Mark Brown
2014-04-02 19:52 ` Mark Brown
2014-04-02 19:52 ` Mark Brown
2014-04-03 3:11 ` Nicolin Chen [this message]
2014-04-03 3:11 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403031116.GA31246@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.