From: Damien Lespiau <damien.lespiau@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Jani Nikula <jani.nikula@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix command parser debug print format mismatches
Date: Thu, 3 Apr 2014 16:44:09 +0100 [thread overview]
Message-ID: <20140403154409.GD18079@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140403093230.GB7225@phenom.ffwll.local>
On Thu, Apr 03, 2014 at 11:32:30AM +0200, Daniel Vetter wrote:
> On Wed, Apr 02, 2014 at 08:26:23AM -0700, Randy Dunlap wrote:
> > On 04/02/2014 01:24 AM, Jani Nikula wrote:
> > > Drop the cast from the pointer diff to fix:
> > >
> > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects
> > > argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int'
> > > [-Wformat]
> > >
> > > While at it, use %u for u32.
> > >
> > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > ---
> > >
> > > Randy, try as I might, I wasn't able to coerce gcc to spit out that
> > > warning. Please enlighten me! (Does this fix the warn?)
> >
> > Yes, it does. Thanks.
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Maybe I'm blind, but I think the recent refactoring patch fixed this. Can
> someone please double-check? I always get confused with printf formats ;-)
I fixed it a couple of weeks back:
http://lists.freedesktop.org/archives/intel-gfx/2014-March/041886.html
--
Damien
WARNING: multiple messages have this Message-ID (diff)
From: Damien Lespiau <damien.lespiau@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Jani Nikula <jani.nikula@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-next@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches
Date: Thu, 3 Apr 2014 16:44:09 +0100 [thread overview]
Message-ID: <20140403154409.GD18079@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140403093230.GB7225@phenom.ffwll.local>
On Thu, Apr 03, 2014 at 11:32:30AM +0200, Daniel Vetter wrote:
> On Wed, Apr 02, 2014 at 08:26:23AM -0700, Randy Dunlap wrote:
> > On 04/02/2014 01:24 AM, Jani Nikula wrote:
> > > Drop the cast from the pointer diff to fix:
> > >
> > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects
> > > argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int'
> > > [-Wformat]
> > >
> > > While at it, use %u for u32.
> > >
> > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > ---
> > >
> > > Randy, try as I might, I wasn't able to coerce gcc to spit out that
> > > warning. Please enlighten me! (Does this fix the warn?)
> >
> > Yes, it does. Thanks.
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Maybe I'm blind, but I think the recent refactoring patch fixed this. Can
> someone please double-check? I always get confused with printf formats ;-)
I fixed it a couple of weeks back:
http://lists.freedesktop.org/archives/intel-gfx/2014-March/041886.html
--
Damien
next prev parent reply other threads:[~2014-04-03 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 7:39 linux-next: Tree for Apr 1 Stephen Rothwell
2014-04-01 7:39 ` Stephen Rothwell
2014-04-01 18:34 ` linux-next: Tree for Apr 1 (netfilter) Randy Dunlap
2014-04-01 19:22 ` David Miller
2014-04-06 13:50 ` Geert Uytterhoeven
2014-04-06 15:31 ` David Miller
2014-04-06 16:08 ` Geert Uytterhoeven
2014-04-01 19:15 ` linux-next: Tree for Apr 1 (drivers/gpu/drm/i915) Randy Dunlap
2014-04-01 19:15 ` Randy Dunlap
2014-04-02 8:24 ` [PATCH] drm/i915: fix command parser debug print format mismatches Jani Nikula
2014-04-02 8:24 ` Jani Nikula
2014-04-02 15:26 ` Randy Dunlap
2014-04-02 15:26 ` Randy Dunlap
2014-04-03 9:32 ` Daniel Vetter
2014-04-03 9:32 ` [Intel-gfx] " Daniel Vetter
2014-04-03 15:44 ` Damien Lespiau [this message]
2014-04-03 15:44 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403154409.GD18079@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.