From: Dave Chinner <david@fromorbit.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
Date: Thu, 03 Apr 2014 19:36:38 +0000 [thread overview]
Message-ID: <20140403193638.GO16336@dastard> (raw)
In-Reply-To: <20140328080313.GA25192@mwanda>
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] xfs: extra semi-colon breaks a condition
Date: Fri, 4 Apr 2014 06:36:38 +1100 [thread overview]
Message-ID: <20140403193638.GO16336@dastard> (raw)
In-Reply-To: <20140328080313.GA25192@mwanda>
On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-03 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 8:03 [patch] xfs: extra semi-colon breaks a condition Dan Carpenter
2014-03-28 8:03 ` Dan Carpenter
2014-03-28 12:09 ` Brian Foster
2014-03-28 12:09 ` Brian Foster
2014-03-29 1:56 ` Eric Sandeen
2014-03-29 1:56 ` Eric Sandeen
2014-03-29 2:08 ` Raphael S Carvalho
2014-04-03 19:36 ` Dave Chinner [this message]
2014-04-03 19:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403193638.GO16336@dastard \
--to=david@fromorbit.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.