From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH nft] expr: do not suppress OP_EQ when RHS is bitmask type
Date: Fri, 4 Apr 2014 10:33:28 +0200 [thread overview]
Message-ID: <20140404083328.GE6769@breakpoint.cc> (raw)
In-Reply-To: <20140404081723.GA3574@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Mon, Mar 17, 2014 at 11:08:38PM +0100, Florian Westphal wrote:
> > bitmask types default to flagcmp now, thus do not suppress OP_EQ. Else,
> >
> > rule filter output tcp flags syn
> > rule filter output tcp flags == syn
> >
> > are both displayed as 'flags syn'.
>
> I believe that in other selectors:
>
> selector == value
> selector value
>
> are equivalent.
Yes, thats true.
> I think it's not just that we have to fix the printing, but make it
> consistent.
Not sure, this was changed recently, see
6bad82aba5d304c7a2dd1b19fe57464dca327f4a
(evaluate: use flagcmp for single RHS bitmask expression).
next prev parent reply other threads:[~2014-04-04 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 22:08 [PATCH nft] expr: do not suppress OP_EQ when RHS is bitmask type Florian Westphal
2014-04-04 8:17 ` Pablo Neira Ayuso
2014-04-04 8:33 ` Florian Westphal [this message]
2014-04-04 9:44 ` Pablo Neira Ayuso
2014-04-04 12:09 ` Patrick McHardy
2014-04-04 14:04 ` Pablo Neira Ayuso
2014-04-04 14:24 ` Patrick McHardy
2014-04-04 15:23 ` Pablo Neira Ayuso
2014-04-04 15:39 ` Florian Westphal
2014-04-04 12:07 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404083328.GE6769@breakpoint.cc \
--to=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.