* [PATCH] Staging: lustre: mark a variable static in workitem.c
@ 2014-04-04 8:22 Mike Sampson
2014-04-04 11:11 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Mike Sampson @ 2014-04-04 8:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Peng Tao, Masanari Iida, Andreas Dilger, Kees Cook, devel,
linux-kernel, trivial, mike
next-20140403: This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?
Signed-off-by: Mike Sampson <mike@sambodata.com>
---
drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/workitem.c
index ba16fd5..0a03bf7 100644
--- a/drivers/staging/lustre/lustre/libcfs/workitem.c
+++ b/drivers/staging/lustre/lustre/libcfs/workitem.c
@@ -75,7 +75,7 @@ typedef struct cfs_wi_sched {
char ws_name[CFS_WS_NAME_LEN];
} cfs_wi_sched_t;
-struct cfs_workitem_data {
+static struct cfs_workitem_data {
/** serialize */
spinlock_t wi_glock;
/** list of all schedulers */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: lustre: mark a variable static in workitem.c
2014-04-04 8:22 [PATCH] Staging: lustre: mark a variable static in workitem.c Mike Sampson
@ 2014-04-04 11:11 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-04 11:11 UTC (permalink / raw)
To: Mike Sampson
Cc: Greg Kroah-Hartman, devel, Andreas Dilger, Kees Cook, Peng Tao,
linux-kernel, trivial
On Fri, Apr 04, 2014 at 07:22:25PM +1100, Mike Sampson wrote:
> next-20140403: This fixes a sparse warning:
^^^^^^^^^^^^^
Just leave this out. Either it applies when Greg gets around to it, or
you'll have to redo it. If you want to add this information then put it
directly after the --- cut off line so it doesn't show up in the
permanent commit log.
The subject should have a [PATCH v2] because this is a second version.
After the --- write:
---
v2: updated the changelog
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-04 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-04 8:22 [PATCH] Staging: lustre: mark a variable static in workitem.c Mike Sampson
2014-04-04 11:11 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.