From: Dan Carpenter <dan.carpenter@oracle.com>
To: s.nawrocki@samsung.com
Cc: linux-samsung-soc@vger.kernel.org
Subject: re: [media] exynos4-is: Add support for asynchronous subdevices registration
Date: Fri, 4 Apr 2014 14:13:36 +0300 [thread overview]
Message-ID: <20140404111336.GA17652@mwanda> (raw)
Hello Sylwester Nawrocki,
This is a semi-automatic email about new static checker warnings.
The patch fa91f1056f17: "[media] exynos4-is: Add support for
asynchronous subdevices registration" from Feb 24, 2014, leads to the
following Smatch complaint:
drivers/media/platform/exynos4-is/media-dev.c:1206 __fimc_md_set_camclk()
warn: variable dereferenced before check 'fmd' (see line 1203)
drivers/media/platform/exynos4-is/media-dev.c
1202 */
1203 if (fmd->pdev->dev.of_node)
^^^^^^^^^
Patch adds a dereference.
1204 return 0;
1205
1206 if (WARN_ON(si->clk_id >= FIMC_MAX_CAMCLKS) || !fmd || !fmd->pmf)
^^^^
Old check.
1207 return -EINVAL;
1208
regards,
dan carpenter
reply other threads:[~2014-04-04 11:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404111336.GA17652@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.