All of lore.kernel.org
 help / color / mirror / Atom feed
* re: [media] exynos4-is: Add support for asynchronous subdevices registration
@ 2014-04-04 11:13 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-04-04 11:13 UTC (permalink / raw)
  To: s.nawrocki; +Cc: linux-samsung-soc

Hello Sylwester Nawrocki,

This is a semi-automatic email about new static checker warnings.

The patch fa91f1056f17: "[media] exynos4-is: Add support for 
asynchronous subdevices registration" from Feb 24, 2014, leads to the 
following Smatch complaint:

drivers/media/platform/exynos4-is/media-dev.c:1206 __fimc_md_set_camclk()
	 warn: variable dereferenced before check 'fmd' (see line 1203)

drivers/media/platform/exynos4-is/media-dev.c
  1202		 */
  1203		if (fmd->pdev->dev.of_node)
                    ^^^^^^^^^
Patch adds a dereference.

  1204			return 0;
  1205	
  1206		if (WARN_ON(si->clk_id >= FIMC_MAX_CAMCLKS) || !fmd || !fmd->pmf)
                                                               ^^^^
Old check.

  1207			return -EINVAL;
  1208	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-04 11:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-04 11:13 [media] exynos4-is: Add support for asynchronous subdevices registration Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.