From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date: Fri, 4 Apr 2014 16:40:43 +0200 [thread overview]
Message-ID: <20140404144043.GB5529@katana> (raw)
In-Reply-To: <201404041628.55471.marex-ynQEQJNshbs@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote:
> On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote:
> > Add dma support for i2c. This function depend on DMA driver.
> > You can turn on it by write both the dmas and dma-name properties in dts
> > node.
> >
> > Signed-off-by: Yuan Yao <yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> [...]
>
> Since you will be fixing that superfluous return 0; (I actually wonder, did you
> really test the driver at all before submitting it?) ...
Good question. @Yuan: Next time, please state what tests you did with
the new version of the driver.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date: Fri, 4 Apr 2014 16:40:43 +0200 [thread overview]
Message-ID: <20140404144043.GB5529@katana> (raw)
In-Reply-To: <201404041628.55471.marex@denx.de>
On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote:
> On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote:
> > Add dma support for i2c. This function depend on DMA driver.
> > You can turn on it by write both the dmas and dma-name properties in dts
> > node.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
>
> [...]
>
> Since you will be fixing that superfluous return 0; (I actually wonder, did you
> really test the driver at all before submitting it?) ...
Good question. @Yuan: Next time, please state what tests you did with
the new version of the driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140404/9d59872d/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Marek Vasut <marex@denx.de>
Cc: Yuan Yao <yao.yuan@freescale.com>,
mark.rutland@arm.com, shawn.guo@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver
Date: Fri, 4 Apr 2014 16:40:43 +0200 [thread overview]
Message-ID: <20140404144043.GB5529@katana> (raw)
In-Reply-To: <201404041628.55471.marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Fri, Apr 04, 2014 at 04:28:55PM +0200, Marek Vasut wrote:
> On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote:
> > Add dma support for i2c. This function depend on DMA driver.
> > You can turn on it by write both the dmas and dma-name properties in dts
> > node.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
>
> [...]
>
> Since you will be fixing that superfluous return 0; (I actually wonder, did you
> really test the driver at all before submitting it?) ...
Good question. @Yuan: Next time, please state what tests you did with
the new version of the driver.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-04 14:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 2:41 [PATCH v4 0/2] i2c: add DMA support for freescale i2c driver Yuan Yao
2014-04-04 2:41 ` Yuan Yao
2014-04-04 2:41 ` Yuan Yao
2014-04-04 2:41 ` [PATCH v4 1/2] " Yuan Yao
2014-04-04 2:41 ` Yuan Yao
2014-04-04 2:41 ` Yuan Yao
[not found] ` <1396579272-19542-2-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-04-04 9:49 ` sourav
2014-04-04 9:49 ` sourav
2014-04-04 9:49 ` sourav
[not found] ` <533E8033.70904-l0cyMroinI0@public.gmane.org>
2014-04-04 10:04 ` sourav
2014-04-04 10:04 ` sourav
2014-04-04 10:04 ` sourav
2014-04-04 11:49 ` Marek Vasut
2014-04-04 11:49 ` Marek Vasut
2014-04-04 11:49 ` Marek Vasut
2014-04-04 14:28 ` Marek Vasut
2014-04-04 14:28 ` Marek Vasut
2014-04-04 14:28 ` Marek Vasut
[not found] ` <201404041628.55471.marex-ynQEQJNshbs@public.gmane.org>
2014-04-04 14:40 ` Wolfram Sang [this message]
2014-04-04 14:40 ` Wolfram Sang
2014-04-04 14:40 ` Wolfram Sang
2014-04-04 15:45 ` Yao Yuan
2014-04-04 15:45 ` Yao Yuan
[not found] ` <aab78696ac364d9c832993c08915bad3-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-04-04 17:40 ` Wolfram Sang
2014-04-04 17:40 ` Wolfram Sang
2014-04-04 17:40 ` Wolfram Sang
2014-05-21 8:00 ` Wolfram Sang
2014-05-21 8:00 ` Wolfram Sang
2014-05-21 8:00 ` Wolfram Sang
2014-07-24 3:19 ` Yao Yuan
2014-07-24 3:19 ` Yao Yuan
2014-07-24 3:19 ` Yao Yuan
[not found] ` <e97f086de6e9427f96ca5ac582031f86-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-07-24 4:14 ` Marek Vasut
2014-07-24 4:14 ` Marek Vasut
2014-07-24 4:14 ` Marek Vasut
[not found] ` <1396579272-19542-1-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-04-04 2:41 ` [PATCH v4 2/2] Documentation:add " Yuan Yao
2014-04-04 2:41 ` Yuan Yao
2014-04-04 2:41 ` Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404144043.GB5529@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.