From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Amit Mehta <gmate.amit@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com, wharms@bfs.de
Subject: Re: [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
Date: Fri, 04 Apr 2014 21:29:28 +0000 [thread overview]
Message-ID: <20140404212928.GY6991@mwanda> (raw)
In-Reply-To: <1396626284-15457-1-git-send-email-gmate.amit@gmail.com>
On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote:
> Kernel style is that if one side of the if else statement gets has curly
> braces then both side should have them.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Looks good, thanks.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Amit Mehta <gmate.amit@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com, wharms@bfs.de
Subject: Re: [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
Date: Sat, 5 Apr 2014 00:29:28 +0300 [thread overview]
Message-ID: <20140404212928.GY6991@mwanda> (raw)
In-Reply-To: <1396626284-15457-1-git-send-email-gmate.amit@gmail.com>
On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote:
> Kernel style is that if one side of the if else statement gets has curly
> braces then both side should have them.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Looks good, thanks.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-04 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 15:44 [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch Kumar Amit Mehta
2014-04-04 15:44 ` Kumar Amit Mehta
2014-04-04 21:29 ` Dan Carpenter [this message]
2014-04-04 21:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404212928.GY6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.