[PATCH] staging/line6: Fix kzalloc coding style issue

[PATCH] staging/line6: Fix kzalloc coding style issue

[L. Alberto Giménez]

Pass the actual variable to sizeof instead of a type definition.

Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
---
 drivers/staging/line6/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 661080b..a3136b1 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
@@ -475,7 +475,7 @@ int line6_init_pcm(struct usb_line6 *line6,
 		MISSING_CASE;
 	}
 
-	line6pcm = kzalloc(sizeof(struct snd_line6_pcm), GFP_KERNEL);
+	line6pcm = kzalloc(sizeof(*line6pcm), GFP_KERNEL);
 
 	if (line6pcm == NULL)
 		return -ENOMEM;
-- 
1.9.1

Re: [PATCH] staging/line6: Fix kzalloc coding style issue

[L. Alberto Giménez]

On Mon, Apr Apr 2014 at 08:05:04AM +0200, Takashi Iwai said:
> At Mon,  7 Apr 2014 00:12:30 +0200,
> L. Alberto Giménez wrote:
> > 
> > Pass the actual variable to sizeof instead of a type definition.
> > 
> > Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
> 
> Acked-by: Takashi Iwai <tiwai@suse.de>
> 
> BTW, does anyone work on line6 stuff actively?
> It's been in staging forever, and it's difficult to promote to the
> standard ALSA driver unless testing with the real hardware by some
> motivated person...

I'm Not sure of that. I think that development has somewhat stalled. I
have line6 hardware that at the moment is not supported (HD500), and I
would like to take the shot. But the problem is that there are no specs,
and Line6 won't release any (I asked, several times, even offering to
accept some kind of stupid NDA). So I would need to reverse engineer
Windows drivers, and I don't have the knowledge to interpret captured
USB traffic, so I'm stuck as well.

I'll try to revive the line6-devel mailing list sending some traffic
captures and see if anyone can help or point me in the right direction.
I would like to see my HD500 running natively on Linux, and it's a nice
challenge to actually do some useful work for the kernel :)


Regards,
L. Alberto Giménez

P.S.: I sent this mail this morning from an alternative machine, and it
seems that the mail configuration was broken. Resending, sorry if you
received this message twice.