All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mauro Chehab <m.chehab@samsung.com>
Subject: Re: [RFC PATCH] time: Fix truncation in jiffies_to_usecs()
Date: Tue, 8 Apr 2014 19:49:51 +0200	[thread overview]
Message-ID: <20140408174946.GA11121@localhost.localdomain> (raw)
In-Reply-To: <CA+8MBb+E_zT47qu4a6pqQWArrhs0gv1W=JKoy252_-Uw6HfbkA@mail.gmail.com>

On Mon, Apr 07, 2014 at 10:34:51PM -0700, Tony Luck wrote:
> On Mon, Apr 7, 2014 at 3:25 PM, Tony Luck <tony.luck@intel.com> wrote:
> 
> > c) If not this ... then what? Separate routine to convert large numbers
> >    of jiffies to usec/nsecs?  Should we make the existing one barf when
> >    handed a number that overflows?
> 
> Having thought about this a bit more - I'm leaning towards leaving
> jiffies_to_usecs() alone, but using it as a model for a from-scratch
> implementation of:
> u64 jiffies_to_nsecs(const unsigned long j)
> {
> }
> 
> This is what the uptime tracer actually needs - and there is only
> one user of jiffies_to_nsecs() to worry about.

I'm not sure I get what you're trying to do. We already have jiffies_to_nsecs().
Anyway I'll just wait and check out the next patch :)

Thanks.

  parent reply	other threads:[~2014-04-08 17:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 22:25 [RFC PATCH] time: Fix truncation in jiffies_to_usecs() Tony Luck
2014-04-08  5:34 ` Tony Luck
2014-04-08 15:27   ` Steven Rostedt
2014-04-08 17:49   ` Frederic Weisbecker [this message]
2014-04-08 18:15     ` Steven Rostedt
2014-04-08 18:56       ` Frederic Weisbecker
2014-04-08 19:34         ` Steven Rostedt
2014-04-08 17:32           ` [PATCH] time: Provide full featured jiffies_to_nsecs() function Tony Luck
2014-04-09 16:53             ` Tony Luck
2014-05-09 21:46               ` Luck, Tony
2014-05-16 14:24             ` Shy Shuky
2014-05-16 17:17               ` Luck, Tony
2014-05-16 19:02                 ` Steven Rostedt
2014-05-19  1:28             ` Xie XiuQi
2014-05-19 22:35               ` Luck, Tony
2014-06-28 11:56                 ` Xie XiuQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408174946.GA11121@localhost.localdomain \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.