From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size
Date: Wed, 9 Apr 2014 09:12:34 +0200 [thread overview]
Message-ID: <20140409091234.20f2e547@skate> (raw)
In-Reply-To: <20140409061128.GC16465@1wt.eu>
Dear Willy Tarreau,
On Wed, 9 Apr 2014 08:11:29 +0200, Willy Tarreau wrote:
> The WARN is correctly emitted for both igb ports here, but unfortunately
> despite EINVAL, I still get the panic. Also I find it surprizing that it
> reports sizes ending in ffff. I read the patch and it looks correct, so
> we possibly have something else wrong here.
Yes, the panic is expected: Jason's patch is not *fixing* anything,
it's just telling you *why* it's going to panic.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Neil Greatorex <neil@fatboyfat.co.uk>,
linux-arm-kernel@lists.infradead.org,
Matthew Minter <matthew_minter@xyratex.com>,
linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size
Date: Wed, 9 Apr 2014 09:12:34 +0200 [thread overview]
Message-ID: <20140409091234.20f2e547@skate> (raw)
In-Reply-To: <20140409061128.GC16465@1wt.eu>
Dear Willy Tarreau,
On Wed, 9 Apr 2014 08:11:29 +0200, Willy Tarreau wrote:
> The WARN is correctly emitted for both igb ports here, but unfortunately
> despite EINVAL, I still get the panic. Also I find it surprizing that it
> reports sizes ending in ffff. I read the patch and it looks correct, so
> we possibly have something else wrong here.
Yes, the panic is expected: Jason's patch is not *fixing* anything,
it's just telling you *why* it's going to panic.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-09 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 23:44 [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size Jason Gunthorpe
2014-04-08 23:44 ` Jason Gunthorpe
2014-04-09 6:11 ` Willy Tarreau
2014-04-09 6:11 ` Willy Tarreau
2014-04-09 7:12 ` Thomas Petazzoni [this message]
2014-04-09 7:12 ` Thomas Petazzoni
2014-04-09 7:47 ` Willy Tarreau
2014-04-09 7:47 ` Willy Tarreau
2014-04-09 7:53 ` Thomas Petazzoni
2014-04-09 7:53 ` Thomas Petazzoni
2014-04-09 7:56 ` Willy Tarreau
2014-04-09 7:56 ` Willy Tarreau
2014-04-09 16:30 ` Jason Gunthorpe
2014-04-09 16:30 ` Jason Gunthorpe
2014-04-09 16:20 ` Jason Gunthorpe
2014-04-09 16:20 ` Jason Gunthorpe
2014-04-10 6:35 ` Willy Tarreau
2014-04-10 6:35 ` Willy Tarreau
2014-04-10 6:53 ` Thomas Petazzoni
2014-04-10 6:53 ` Thomas Petazzoni
2014-04-10 11:59 ` Jason Cooper
2014-04-10 11:59 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409091234.20f2e547@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.