All of lore.kernel.org
 help / color / mirror / Atom feed
* re: Add WMI driver for controlling AlienFX features on some Alienware products
@ 2014-04-09 15:20 Dan Carpenter
  2014-04-09 15:50 ` Mario Limonciello
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-04-09 15:20 UTC (permalink / raw)
  To: mario_limonciello; +Cc: platform-driver-x86

Hello Mario Limonciello,

This is a semi-automatic email about new static checker warnings.

The patch d17a5ee12973: "Add WMI driver for controlling AlienFX
features on some Alienware products" from Apr 4, 2014, leads to the
following Smatch complaint:

drivers/platform/x86/alienware-wmi.c:551 alienware_wmi_exit()
	 warn: variable dereferenced before check 'platform_device' (see line 549)

drivers/platform/x86/alienware-wmi.c
   548	{
   549		alienware_zone_exit(platform_device);
                                    ^^^^^^^^^^^^^^^
   550		remove_hdmi(platform_device);
                            ^^^^^^^^^^^^^^^
   551		if (platform_device) {
                    ^^^^^^^^^^^^^^^
   552			platform_device_unregister(platform_device);
   553			platform_driver_unregister(&platform_driver);

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Add WMI driver for controlling AlienFX features on some Alienware products
  2014-04-09 15:20 Add WMI driver for controlling AlienFX features on some Alienware products Dan Carpenter
@ 2014-04-09 15:50 ` Mario Limonciello
  0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2014-04-09 15:50 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: platform-driver-x86@vger.kernel.org


On 04/09/2014 10:20 AM, Dan Carpenter wrote:
> Hello Mario Limonciello,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch d17a5ee12973: "Add WMI driver for controlling AlienFX
> features on some Alienware products" from Apr 4, 2014, leads to the
> following Smatch complaint:
>
> drivers/platform/x86/alienware-wmi.c:551 alienware_wmi_exit()
> 	 warn: variable dereferenced before check 'platform_device' (see line 549)
>
> drivers/platform/x86/alienware-wmi.c
>     548	{
>     549		alienware_zone_exit(platform_device);
>                                      ^^^^^^^^^^^^^^^
>     550		remove_hdmi(platform_device);
>                              ^^^^^^^^^^^^^^^
>     551		if (platform_device) {
>                      ^^^^^^^^^^^^^^^
>     552			platform_device_unregister(platform_device);
>     553			platform_driver_unregister(&platform_driver);
>
> regards,
> dan carpenter
Hi Dan,

Thanks for letting me know.  I did submit a follow up patch for this behavior here a few days ago:

http://www.spinics.net/lists/platform-driver-x86/msg05233.html

Thanks,

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-09 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 15:20 Add WMI driver for controlling AlienFX features on some Alienware products Dan Carpenter
2014-04-09 15:50 ` Mario Limonciello

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.