All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: jon ernst <jonernst07@gmail.com>
Cc: "linux-ext4@vger.kernel.org List" <linux-ext4@vger.kernel.org>
Subject: Re: xfstest-bld generic/018 fails due to e4defrag issue
Date: Wed, 9 Apr 2014 18:03:20 -0400	[thread overview]
Message-ID: <20140409220320.GC15303@thunk.org> (raw)
In-Reply-To: <CAGW2f1F1sL+if9zejgB92j0YDRjswvB3LG_dBR+pK3Yj4aQfHQ@mail.gmail.com>

On Wed, Apr 09, 2014 at 01:37:04AM -0400, jon ernst wrote:
> running latest xfstest-bld with latest ext4 kernel "dev"
> branch(ad6599ab3a).I always get generic/018 failed.
> Then I took closer look and found out this issue.

That's a renamed tested; it was previously shared/218.  It's a test
which is known to fail for ext4, since its idea of how a defrag
program should work is slightly different from how e4defrag works:

shared/218 7s ...   [20:48:32] [20:48:39] - output mismatch (see /results/results-4k/shared/218.out.bad)
    --- tests/shared/218.out   2014-04-01 18:46:39.000000000 +0000
    +++ /results/results-4k/shared/218.out.bad		     2014-04-03 20:48:39.795694518 +0000
    @@ -10,7 +10,7 @@
     After: 1
     Write backwards sync, but contiguous - should defrag to 1 extent
     Before: 10
    -After: 1
    +After: 10
     Write backwards sync leaving holes - defrag should do nothing
     Before: 16
    ...
    (Run 'diff -u tests/shared/218.out /results/results-4k/shared/218.out.bad'  to see the entire diff)

What you are seeing is something very different, though.

> Even though the file does exist. e4defrag complains about:
> 
> (this output comes from kvm guest machine)
> > e4defrag -v /vdf/testfile
> Can't get super block info: Success
> "/vdf/testfile"
> 
> Is this a known issue or something I did wrong.

Unfortunately, e4defrag has horrible error handling, so we can't see
the error code properly, so we can't see why it's failing, but this is
from an attempt to open the file system to get some low-level
information.

How is /etc/mtab set up on your test machine?  It looks like it failed
to find block device for the file system in question.

   	      	     	     	  	 - Ted

  reply	other threads:[~2014-04-09 22:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09  5:37 xfstest-bld generic/018 fails due to e4defrag issue jon ernst
2014-04-09 22:03 ` Theodore Ts'o [this message]
2014-04-10  4:13   ` jon ernst
2014-04-10 13:56     ` Theodore Ts'o
2014-04-10 18:42       ` Darrick J. Wong
2014-04-11  3:07         ` Theodore Ts'o
2014-04-11  3:10           ` jon ernst
2014-04-11  3:17             ` [PATCH] e4defrag: fix error reporting when ext2fs_open fails Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409220320.GC15303@thunk.org \
    --to=tytso@mit.edu \
    --cc=jonernst07@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.