From: Theodore Ts'o <tytso@mit.edu>
To: jon ernst <jonernst07@gmail.com>
Cc: "linux-ext4@vger.kernel.org List" <linux-ext4@vger.kernel.org>
Subject: Re: xfstest-bld generic/018 fails due to e4defrag issue
Date: Thu, 10 Apr 2014 09:56:37 -0400 [thread overview]
Message-ID: <20140410135637.GC15925@thunk.org> (raw)
In-Reply-To: <CAGW2f1Fn2caBtQPjZnXyMdVf9H6wGvS_0YrLReggwujKZXL8CQ@mail.gmail.com>
On Thu, Apr 10, 2014 at 12:13:49AM -0400, jon ernst wrote:
>
> Because bigalloc requires cluster-aware bitfield operations, which
> means we need EXT2_FLAG_64BITS.
> I see e2image.c creates image always with EXT2_FLAG_64BITS flag. It is
> safe to do same thing for e4defrag in my opinion. Please correct me if
> I am wrong.
Um.... I *think* so. e4defrag is one of the less well
tested/maintained parts of e2fsprogs, as well as the kernel-side code
which supports e4defrag. I can't think of any reason why there would
be any 32-bit dependencies in the kernel side code, although someone
should probably do a quick audit of the e4defrag code to make sure
it's not using blk_t where it should be using blk64_t, or have other
32-bit dependencies.
- Ted
next prev parent reply other threads:[~2014-04-10 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 5:37 xfstest-bld generic/018 fails due to e4defrag issue jon ernst
2014-04-09 22:03 ` Theodore Ts'o
2014-04-10 4:13 ` jon ernst
2014-04-10 13:56 ` Theodore Ts'o [this message]
2014-04-10 18:42 ` Darrick J. Wong
2014-04-11 3:07 ` Theodore Ts'o
2014-04-11 3:10 ` jon ernst
2014-04-11 3:17 ` [PATCH] e4defrag: fix error reporting when ext2fs_open fails Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410135637.GC15925@thunk.org \
--to=tytso@mit.edu \
--cc=jonernst07@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.