From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Simon Horman <horms@verge.net.au>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: use PWM_LOOKUP to set the period and polarity
Date: Thu, 10 Apr 2014 09:37:03 +0200 [thread overview]
Message-ID: <20140410073702.GF2879@piout.net> (raw)
In-Reply-To: <20140409231549.GD2187@verge.net.au>
On 10/04/2014 at 08:15:49 +0900, Simon Horman wrote :
> On Wed, Apr 09, 2014 at 08:04:09PM +0200, Alexandre Belloni wrote:
> > Now that the PWM core is able to set the period and polarity based on
> > the lookup table, add those to PWM_LOOKUP to ease their usage.
>
> I would prefer if this change was made in a non-atomic manner.
>
> 1. Add new infrastructure
> 2. Update users individually
> 3. Remove old infrastructure
>
I agree this would be better but I'm not sure how you can modify a macro
without renaming it or changing it everywhere at once. Like said, I'm
open to creating a new macro.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pwm: use PWM_LOOKUP to set the period and polarity
Date: Thu, 10 Apr 2014 07:37:03 +0000 [thread overview]
Message-ID: <20140410073702.GF2879@piout.net> (raw)
In-Reply-To: <20140409231549.GD2187@verge.net.au>
On 10/04/2014 at 08:15:49 +0900, Simon Horman wrote :
> On Wed, Apr 09, 2014 at 08:04:09PM +0200, Alexandre Belloni wrote:
> > Now that the PWM core is able to set the period and polarity based on
> > the lookup table, add those to PWM_LOOKUP to ease their usage.
>
> I would prefer if this change was made in a non-atomic manner.
>
> 1. Add new infrastructure
> 2. Update users individually
> 3. Remove old infrastructure
>
I agree this would be better but I'm not sure how you can modify a macro
without renaming it or changing it everywhere at once. Like said, I'm
open to creating a new macro.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pwm: use PWM_LOOKUP to set the period and polarity
Date: Thu, 10 Apr 2014 09:37:03 +0200 [thread overview]
Message-ID: <20140410073702.GF2879@piout.net> (raw)
In-Reply-To: <20140409231549.GD2187@verge.net.au>
On 10/04/2014 at 08:15:49 +0900, Simon Horman wrote :
> On Wed, Apr 09, 2014 at 08:04:09PM +0200, Alexandre Belloni wrote:
> > Now that the PWM core is able to set the period and polarity based on
> > the lookup table, add those to PWM_LOOKUP to ease their usage.
>
> I would prefer if this change was made in a non-atomic manner.
>
> 1. Add new infrastructure
> 2. Update users individually
> 3. Remove old infrastructure
>
I agree this would be better but I'm not sure how you can modify a macro
without renaming it or changing it everywhere at once. Like said, I'm
open to creating a new macro.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-10 7:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 18:04 [PATCH 0/2] improve pwm lookup support without device tree Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 18:04 ` [PATCH 1/2] pwm: add period and polarity to struct pwm_lookup Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 19:37 ` Russell King - ARM Linux
2014-04-09 19:37 ` Russell King - ARM Linux
2014-04-09 19:37 ` Russell King - ARM Linux
2014-04-09 20:52 ` Alexandre Belloni
2014-04-09 20:52 ` Alexandre Belloni
2014-04-09 20:52 ` Alexandre Belloni
2014-04-09 18:04 ` [PATCH 2/2] pwm: use PWM_LOOKUP to set the period and polarity Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 18:04 ` Alexandre Belloni
2014-04-09 23:15 ` Simon Horman
2014-04-09 23:15 ` Simon Horman
2014-04-09 23:15 ` Simon Horman
2014-04-10 7:37 ` Alexandre Belloni [this message]
2014-04-10 7:37 ` Alexandre Belloni
2014-04-10 7:37 ` Alexandre Belloni
2014-04-14 2:03 ` Simon Horman
2014-04-14 2:03 ` Simon Horman
2014-04-14 2:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410073702.GF2879@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=magnus.damm@gmail.com \
--cc=philipp.zabel@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.