From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH RESEND 2/2] tracing: syscall_regfunc() should not skip kernel threads
Date: Thu, 10 Apr 2014 15:38:55 +0200 [thread overview]
Message-ID: <20140410133855.GC12228@redhat.com> (raw)
In-Reply-To: <20140410092842.1f9a8760@gandalf.local.home>
On 04/10, Steven Rostedt wrote:
>
> On Wed, 9 Apr 2014 19:06:16 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > syscall_regfunc() ignores the kernel thread because "it has
> > no effect", see cc3b13c1 "Don't trace kernel thread syscalls".
> >
> > However, this means that a user-space task spawned by
> > call_usermodehelper() won't report the system calls if
> > kernel_execve() is called when sys_tracepoint_refcount != 0.
>
> What about doing the set there? That is, we could add a check in the
> call_userspacehelper() just before it does the do_execve, that if
> sys_tracepoint_refcount is set, we set the TIF flag.
But for what?
And if we do this, ____call_usermodehelper() needs write_lock_irq(tasklist)
to serialize with syscall_*regfunc().
Oleg.
next prev parent reply other threads:[~2014-04-10 13:38 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 16:11 [PATCH 0/5] core: Convert thread iteration to use for_each[_process]_thread APIs, 1st pile Frederic Weisbecker
2014-04-09 16:11 ` [PATCH 1/5] sched: Convert thread_group_cputime() to use for_each_thread() Frederic Weisbecker
2014-04-09 17:12 ` Oleg Nesterov
2014-04-09 17:16 ` Peter Zijlstra
2014-04-09 17:32 ` Oleg Nesterov
2014-04-09 18:30 ` Peter Zijlstra
2014-04-09 19:46 ` Oleg Nesterov
2014-04-09 19:49 ` Peter Zijlstra
2014-04-10 16:19 ` Peter Zijlstra
2014-04-10 16:32 ` Peter Zijlstra
2014-04-10 17:29 ` Oleg Nesterov
2014-04-10 17:36 ` Peter Zijlstra
2014-04-10 17:42 ` Peter Zijlstra
2014-04-10 19:15 ` Oleg Nesterov
2014-04-10 20:55 ` Peter Zijlstra
2014-04-10 7:56 ` Ingo Molnar
2014-04-09 16:11 ` [PATCH 2/5] tracepoint: Convert process iteration to use for_each_process_thread() Frederic Weisbecker
2014-04-09 16:28 ` Mathieu Desnoyers
2014-04-09 16:40 ` Frederic Weisbecker
2014-04-09 16:42 ` Steven Rostedt
2014-04-09 17:05 ` [PATCH 0/2] Was: " Oleg Nesterov
2014-04-09 17:05 ` [PATCH RESEND 1/2] tracing: syscall_*regfunc() can race with copy_process() Oleg Nesterov
2014-04-10 13:04 ` Steven Rostedt
2014-04-10 13:33 ` Oleg Nesterov
2014-04-10 13:06 ` Steven Rostedt
2014-04-10 13:34 ` Oleg Nesterov
2014-04-11 15:22 ` Steven Rostedt
2014-04-11 15:58 ` Oleg Nesterov
2014-04-13 18:58 ` [PATCH v2 0/3] tracing: syscall_*regfunc() fixes Oleg Nesterov
2014-04-13 18:58 ` [PATCH v2 1/3] tracing: fix syscall_*regfunc() vs copy_process() race Oleg Nesterov
2014-04-14 23:57 ` Frederic Weisbecker
2014-04-13 18:59 ` [PATCH v2 2/3] tracing: change syscall_*regfunc() to check PF_KTHREAD and use for_each_process_thread() Oleg Nesterov
2014-04-13 18:59 ` [PATCH v2 3/3] tracing: syscall_regfunc() should not skip kernel threads Oleg Nesterov
2014-04-14 23:46 ` [PATCH v2 0/3] tracing: syscall_*regfunc() fixes Frederic Weisbecker
2014-06-18 14:23 ` Steven Rostedt
2014-06-18 15:36 ` Oleg Nesterov
2014-04-09 17:06 ` [PATCH RESEND 2/2] tracing: syscall_regfunc() should not skip kernel threads Oleg Nesterov
2014-04-10 13:28 ` Steven Rostedt
2014-04-10 13:38 ` Oleg Nesterov [this message]
2014-04-10 14:28 ` Steven Rostedt
2014-04-10 14:46 ` Oleg Nesterov
2014-04-10 15:08 ` Steven Rostedt
2014-04-10 17:57 ` Oleg Nesterov
2014-04-10 18:14 ` Oleg Nesterov
2014-04-10 19:00 ` Oleg Nesterov
2014-04-10 19:13 ` Steven Rostedt
2014-04-10 19:38 ` Oleg Nesterov
2014-04-10 19:55 ` Steven Rostedt
2014-04-11 12:03 ` Oleg Nesterov
2014-04-11 12:37 ` Steven Rostedt
2014-04-10 13:03 ` [PATCH 0/2] Was: Convert process iteration to use for_each_process_thread() Steven Rostedt
2014-04-09 16:11 ` [PATCH 3/5] hung_task: " Frederic Weisbecker
2014-04-09 17:23 ` Oleg Nesterov
2014-04-09 16:11 ` [PATCH 4/5] procfs: Convert process iteration to use for_each_thread() Frederic Weisbecker
2014-04-09 16:11 ` [PATCH 5/5] sched: Convert tasks iteration to use for_each_process_thread() Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410133855.GC12228@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.