From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: peter.maydell@linaro.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 0/4] CVE-2013-4544
Date: Fri, 11 Apr 2014 15:26:10 +0100 [thread overview]
Message-ID: <20140411142610.GM2430@work-vm> (raw)
In-Reply-To: <1396604722-11902-1-git-send-email-dmitry@daynix.com>
* Dmitry Fleytman (dmitry@daynix.com) wrote:
> Changes since V1:
>
> * Comments added and extended as sugested by Dave and Michael
>
> Dmitry Fleytman (4):
> vmxnet3: validate interrupt indices coming from guest
> vmxnet3: validate queues configuration coming from quest
> vmxnet3: validate interrupt indices read on migration
> vmxnet3: validate queues configuration read on migration
I've reviewed all of those as OK; if you ever get the chance
I think it would be nicer to try and avoid hw_error that causes an
abort, especially when that's guest (even in this case a broken one)
triggerable.
But, lets get the fix in.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2014-04-11 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 9:45 [Qemu-devel] [PATCH V2 0/4] CVE-2013-4544 Dmitry Fleytman
2014-04-04 9:45 ` [Qemu-devel] [PATCH V2 1/4] vmxnet3: validate interrupt indices coming from guest Dmitry Fleytman
2014-04-11 14:05 ` Dr. David Alan Gilbert
2014-04-04 9:45 ` [Qemu-devel] [PATCH V2 2/4] vmxnet3: validate queues configuration coming from quest Dmitry Fleytman
2014-04-11 14:10 ` Dr. David Alan Gilbert
2014-04-04 9:45 ` [Qemu-devel] [PATCH V2 3/4] vmxnet3: validate interrupt indices read on migration Dmitry Fleytman
2014-04-11 14:21 ` Dr. David Alan Gilbert
2014-04-04 9:45 ` [Qemu-devel] [PATCH V2 4/4] vmxnet3: validate queues configuration " Dmitry Fleytman
2014-04-11 14:23 ` Dr. David Alan Gilbert
2014-04-11 14:26 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411142610.GM2430@work-vm \
--to=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.