From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, kmo@daterainc.com, Milan Broz <gmazyland@gmail.com>
Subject: Re: dm-verity: Fix biovecs hash calculation regression
Date: Mon, 14 Apr 2014 17:11:20 -0400 [thread overview]
Message-ID: <20140414211119.GA24873@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1404141629040.22418@file01.intranet.prod.int.rdu2.redhat.com>
On Mon, Apr 14 2014 at 4:29pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Mon, 14 Apr 2014, Milan Broz wrote:
>
> > The commit
> > 003b5c5719f159f4f4bf97511c4702a0638313dd
> > block: Convert drivers to immutable biovecs
> >
> > incorrectly converted biovec iteration in dm-verity to always
> > calculate hash from full biovec, while the function need
> > to calculate hash only from part of it (up to "todo"
> > calculated value).
> >
> > This patch fixes the issue by limiting hash input to only
> > really requested data size.
> >
> > The problem is easily reproducible using cryptsetup
> > regression test for veritysetup (verity-compat-test).
> >
> > (Patch should be applied also to 3.14 stable.)
> >
> > Signed-off-by: Milan Broz <gmazyland@gmail.com>
>
> Acked-by: Mikulas Patocka <mpatocka@redhat.com>
> Cc: stable@vger.kernel.org # 3.14
I'll pick this up to include in 3.15 fixes that I'll be sending to Linus.
prev parent reply other threads:[~2014-04-14 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 20:02 [PATCH] dm-verity: Fix biovecs hash calculation regression Milan Broz
2014-04-14 20:29 ` Mikulas Patocka
2014-04-14 21:11 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414211119.GA24873@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=kmo@daterainc.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.