All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: fix eDMA driver as a subsys_initcall
Date: Wed, 16 Apr 2014 12:04:27 +0530	[thread overview]
Message-ID: <20140416063427.GK32284@intel.com> (raw)
In-Reply-To: <1396585675-32729-1-git-send-email-yao.yuan@freescale.com>

On Fri, Apr 04, 2014 at 12:27:55PM +0800, Yuan Yao wrote:
> Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Changelog could have mentioned "which" driver and elobrated on it
> 
> Signed-off-by: Yuan Yao <yao.yuan@freescale.com>

Applied, nevertheless

-- 
~Vinod
> ---
>  drivers/dma/fsl-edma.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index 381e793..b396a7f 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
>  	.remove		= fsl_edma_remove,
>  };
>  
> -module_platform_driver(fsl_edma_driver);
> +static int __init fsl_edma_init(void)
> +{
> +	return platform_driver_register(&fsl_edma_driver);
> +}
> +subsys_initcall(fsl_edma_init);
> +
> +static void __exit fsl_edma_exit(void)
> +{
> +	platform_driver_unregister(&fsl_edma_driver);
> +}
> +module_exit(fsl_edma_exit);
>  
>  MODULE_ALIAS("platform:fsl-edma");
>  MODULE_DESCRIPTION("Freescale eDMA engine driver");
> -- 
> 1.8.4
> 
> 

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Yuan Yao <yao.yuan@freescale.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, jingchang.lu@freecsale.com
Subject: Re: [PATCH] dma: fix eDMA driver as a subsys_initcall
Date: Wed, 16 Apr 2014 12:04:27 +0530	[thread overview]
Message-ID: <20140416063427.GK32284@intel.com> (raw)
In-Reply-To: <1396585675-32729-1-git-send-email-yao.yuan@freescale.com>

On Fri, Apr 04, 2014 at 12:27:55PM +0800, Yuan Yao wrote:
> Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Changelog could have mentioned "which" driver and elobrated on it
> 
> Signed-off-by: Yuan Yao <yao.yuan@freescale.com>

Applied, nevertheless

-- 
~Vinod
> ---
>  drivers/dma/fsl-edma.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index 381e793..b396a7f 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
>  	.remove		= fsl_edma_remove,
>  };
>  
> -module_platform_driver(fsl_edma_driver);
> +static int __init fsl_edma_init(void)
> +{
> +	return platform_driver_register(&fsl_edma_driver);
> +}
> +subsys_initcall(fsl_edma_init);
> +
> +static void __exit fsl_edma_exit(void)
> +{
> +	platform_driver_unregister(&fsl_edma_driver);
> +}
> +module_exit(fsl_edma_exit);
>  
>  MODULE_ALIAS("platform:fsl-edma");
>  MODULE_DESCRIPTION("Freescale eDMA engine driver");
> -- 
> 1.8.4
> 
> 

-- 

  reply	other threads:[~2014-04-16  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  4:27 [PATCH] dma: fix eDMA driver as a subsys_initcall Yuan Yao
2014-04-04  4:27 ` Yuan Yao
2014-04-16  6:34 ` Vinod Koul [this message]
2014-04-16  6:34   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416063427.GK32284@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.