From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: Fix incorrect sizeof() in sst_hsw_stream_get_volume()
Date: Wed, 16 Apr 2014 18:33:56 +0300 [thread overview]
Message-ID: <20140416152815.GG4963@mwanda> (raw)
In-Reply-To: <20140413195636.32f31cb2@spike>
On Sun, Apr 13, 2014 at 07:56:36PM +0200, Christian Engelmayer wrote:
> Fix an incorrect sizeof() usage in sst_hsw_stream_get_volume(). sst_dsp_read()
> is called to read into a variable of type u32, but is passed sizeof(u32 *) for
> argument 'size_t bytes'. Detected by Coverity: CID 1195260.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
There are a couple others in this file. I introduced one of them. :(
Sorry about that. I'll send a patch for that.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Fix incorrect sizeof() in sst_hsw_stream_get_volume()
Date: Wed, 16 Apr 2014 18:33:56 +0300 [thread overview]
Message-ID: <20140416152815.GG4963@mwanda> (raw)
In-Reply-To: <20140413195636.32f31cb2@spike>
On Sun, Apr 13, 2014 at 07:56:36PM +0200, Christian Engelmayer wrote:
> Fix an incorrect sizeof() usage in sst_hsw_stream_get_volume(). sst_dsp_read()
> is called to read into a variable of type u32, but is passed sizeof(u32 *) for
> argument 'size_t bytes'. Detected by Coverity: CID 1195260.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
There are a couple others in this file. I introduced one of them. :(
Sorry about that. I'll send a patch for that.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-16 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 17:56 [PATCH] ASoC: Intel: Fix incorrect sizeof() in sst_hsw_stream_get_volume() Christian Engelmayer
2014-04-13 17:56 ` Christian Engelmayer
2014-04-15 11:13 ` Mark Brown
2014-04-16 15:33 ` Dan Carpenter [this message]
2014-04-16 15:33 ` Dan Carpenter
2014-04-16 15:38 ` [patch] ASoC: Intel: some incorrect sizeof() usages Dan Carpenter
2014-04-16 15:38 ` Dan Carpenter
2014-04-18 16:11 ` Mark Brown
2014-04-18 16:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416152815.GG4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cengelma@gmx.at \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.