All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sparc64: Make itc_sync_lock raw
@ 2014-04-16 20:45 Kirill Tkhai
  0 siblings, 0 replies; 2+ messages in thread
From: Kirill Tkhai @ 2014-04-16 20:45 UTC (permalink / raw)
  To: sparclinux

One more place where we must not be able
to be preempted or to be interrupted in RT.

Always actually disable interrupts during
synchronization cycle.

Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
---
 arch/sparc/kernel/smp_64.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
index 9781048..745a363 100644
--- a/arch/sparc/kernel/smp_64.c
+++ b/arch/sparc/kernel/smp_64.c
@@ -149,7 +149,7 @@ void cpu_panic(void)
 #define NUM_ROUNDS	64	/* magic value */
 #define NUM_ITERS	5	/* likewise */
 
-static DEFINE_SPINLOCK(itc_sync_lock);
+static DEFINE_RAW_SPINLOCK(itc_sync_lock);
 static unsigned long go[SLAVE + 1];
 
 #define DEBUG_TICK_SYNC	0
@@ -257,7 +257,7 @@ static void smp_synchronize_one_tick(int cpu)
 	go[MASTER] = 0;
 	membar_safe("#StoreLoad");
 
-	spin_lock_irqsave(&itc_sync_lock, flags);
+	raw_spin_lock_irqsave(&itc_sync_lock, flags);
 	{
 		for (i = 0; i < NUM_ROUNDS*NUM_ITERS; i++) {
 			while (!go[MASTER])
@@ -268,7 +268,7 @@ static void smp_synchronize_one_tick(int cpu)
 			membar_safe("#StoreLoad");
 		}
 	}
-	spin_unlock_irqrestore(&itc_sync_lock, flags);
+	raw_spin_unlock_irqrestore(&itc_sync_lock, flags);
 }
 
 #if defined(CONFIG_SUN_LDOMS) && defined(CONFIG_HOTPLUG_CPU)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sparc64: Make itc_sync_lock raw
@ 2014-05-02  5:15 David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-02  5:15 UTC (permalink / raw)
  To: sparclinux

From: Kirill Tkhai <tkhai@yandex.ru>
Date: Thu, 17 Apr 2014 00:45:24 +0400

> One more place where we must not be able
> to be preempted or to be interrupted in RT.
> 
> Always actually disable interrupts during
> synchronization cycle.
> 
> Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>

Applied, thanks Kirill.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-02  5:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-16 20:45 [PATCH] sparc64: Make itc_sync_lock raw Kirill Tkhai
  -- strict thread matches above, loose matches on Subject: below --
2014-05-02  5:15 David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.