From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters
Date: Wed, 16 Apr 2014 19:34:04 -0700 [thread overview]
Message-ID: <20140417023404.GA6290@kroah.com> (raw)
In-Reply-To: <534F1C6E.7010606@gmail.com>
On Wed, Apr 16, 2014 at 05:12:30PM -0700, Frank Rowand wrote:
> pr_debug() parameters are reverse order of format string
>
> Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com>
> ---
>
> drivers/base/dd.c | 4 2 + 2 - 0 !
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/base/dd.c
> ===================================================================
What is this, cvs? :)
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -187,8 +187,8 @@ static void driver_bound(struct device *
> return;
> }
>
> - pr_debug("driver: '%s': %s: bound to device '%s'\n", dev_name(dev),
> - __func__, dev->driver->name);
> + pr_debug("driver: '%s': %s: bound to device '%s'\n", dev->driver->name,
> + __func__, dev_name(dev));
Thanks, I'll queue this up.
greg k-h
prev parent reply other threads:[~2014-04-17 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 0:12 [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters Frank Rowand
2014-04-17 0:48 ` Joe Perches
2014-04-17 1:12 ` Frank Rowand
2014-04-17 1:23 ` Joe Perches
2014-04-17 2:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417023404.GA6290@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.