From: Frank Rowand <frowand.list@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters
Date: Wed, 16 Apr 2014 18:12:40 -0700 [thread overview]
Message-ID: <534F2A88.8050408@gmail.com> (raw)
In-Reply-To: <1397695738.4603.2.camel@joe-AO725>
On 4/16/2014 5:48 PM, Joe Perches wrote:
> On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote:
>> pr_debug() parameters are reverse order of format string
>
> Another way to do this might be to change all the
> printks/pr_debugs to dev_<level>
Yes, but if that is done, one may as well do all of drivers/base/*.c
and drivers/base/*/*.c
I was only trying to fix incorrectly reported information from one
pr_debug(). If someone else want to do a big conversion, they are
free to. :-)
>
> Something like:
> ---
> drivers/base/dd.c | 35 +++++++++++++++++------------------
> 1 file changed, 17 insertions(+), 18 deletions(-)
>
< snip >
next prev parent reply other threads:[~2014-04-17 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 0:12 [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters Frank Rowand
2014-04-17 0:48 ` Joe Perches
2014-04-17 1:12 ` Frank Rowand [this message]
2014-04-17 1:23 ` Joe Perches
2014-04-17 2:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534F2A88.8050408@gmail.com \
--to=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.