From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: Clear cached acl after setting a zero-length default posix acl:
Date: Fri, 18 Apr 2014 08:13:53 -0400 [thread overview]
Message-ID: <20140418121353.GC18612@fieldses.org> (raw)
In-Reply-To: <20140417143634.GA20857@infradead.org>
On Thu, Apr 17, 2014 at 07:36:34AM -0700, Christoph Hellwig wrote:
> On Thu, Apr 17, 2014 at 08:46:11PM +0800, Kinglong Mee wrote:
> > After setting ACL for directory, I got two problems that caused
> > by the cached zero-length default posix acl.
> >
> > This patch just clears the cached zero-length default posix acl
> > after setting.
> >
> > First problem:
> > # nfs4_setfacl -s A::OWNER@:RWX /mnt/123/; touch /mnt/123/test
> > ............ hang ...........
>
> Nfsd must not call forget_cached_acl, that's the filesystems job.
> I think the right fix is to make sure nfsd4_set_nfs4_acl calls ->set_acl
> with a NULL ACL structure if there are no entries.
>
> Btw, it would be really good if we kept tests like this as a regression
> test suite. Is there one for NFS already? If not we could add
> nfs-specific tests to xfstests as well.
I'd recommend pynfs for something like this.
(It talks NFSv4 directly to the server, so won't depend on client
acl-caching behavior, etc.)
--b.
next prev parent reply other threads:[~2014-04-18 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 12:46 [PATCH] NFSD: Clear cached acl after setting a zero-length default posix acl: Kinglong Mee
2014-04-17 14:36 ` Christoph Hellwig
2014-04-18 3:48 ` [PATCH v2] NFSD: Don't set default ACL if there are no ACE entries Kinglong Mee
2014-04-18 12:19 ` J. Bruce Fields
2014-04-18 12:49 ` [PATCH v3] NFSD: Call ->set_acl with a NULL ACL structure if no entries Kinglong Mee
2014-05-08 16:41 ` J. Bruce Fields
2014-04-18 12:56 ` [PATCH v2] NFSD: Don't set default ACL if there are no ACE entries Kinglong Mee
2014-04-18 13:47 ` Christoph Hellwig
2014-04-18 4:03 ` [PATCH] NFSD: Clear cached acl after setting a zero-length default posix acl: Kinglong Mee
2014-04-18 12:13 ` J. Bruce Fields [this message]
2014-04-18 12:26 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418121353.GC18612@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.