From: Christoph Hellwig <hch@infradead.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Kinglong Mee <kinglongmee@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] NFSD: Don't set default ACL if there are no ACE entries
Date: Fri, 18 Apr 2014 06:47:25 -0700 [thread overview]
Message-ID: <20140418134725.GA30815@infradead.org> (raw)
In-Reply-To: <20140418121920.GD18612@fieldses.org>
On Fri, Apr 18, 2014 at 08:19:20AM -0400, J. Bruce Fields wrote:
> I thought Christoph's suggestion was to actually call ->set_acl with a
> NULL ACL? Does that turn out to be unnecessary?
It's a no-op if there wasn't a previous ACL on the inode, but if there
was it needs to be removed by passing the NULL acl argument.
next prev parent reply other threads:[~2014-04-18 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 12:46 [PATCH] NFSD: Clear cached acl after setting a zero-length default posix acl: Kinglong Mee
2014-04-17 14:36 ` Christoph Hellwig
2014-04-18 3:48 ` [PATCH v2] NFSD: Don't set default ACL if there are no ACE entries Kinglong Mee
2014-04-18 12:19 ` J. Bruce Fields
2014-04-18 12:49 ` [PATCH v3] NFSD: Call ->set_acl with a NULL ACL structure if no entries Kinglong Mee
2014-05-08 16:41 ` J. Bruce Fields
2014-04-18 12:56 ` [PATCH v2] NFSD: Don't set default ACL if there are no ACE entries Kinglong Mee
2014-04-18 13:47 ` Christoph Hellwig [this message]
2014-04-18 4:03 ` [PATCH] NFSD: Clear cached acl after setting a zero-length default posix acl: Kinglong Mee
2014-04-18 12:13 ` J. Bruce Fields
2014-04-18 12:26 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418134725.GA30815@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.